RomRaider

That's my understanding as well.

This would help. I know the 3D graphing is attempting to use the scale min/max to determine an appropriate bounds for the x and y coordinates. This would be useful information to have added to our scaling defs.

Review up to your branch commit:
https://github.com/scotthew/RomRaider/c ... b9c4668aaf
Here's what I've found after a few days of playing with the compiled standalone (ZIP) version on java.runtime.version=1.7.0_25-b17 Win XP.

• The Scaling selection font is not consistent with the other buttons and fields on the toolbar.
• Column headings are squished on some tables but not others. See Feedback Correction Range (RPM) for an example.
• When viewing data in raw value display the increment/decrement values remain float rather than switch too (are they supposed to switch?)
• When viewing data as raw value, display increments work on the table cell values but not decrements
• Cell borders, increase is blue and decrease is red (did we not switch these?)
• Table load error if axis element <table type="X Axis" name="" /> has a null or undefined name (the name of the table could be helpful in the message)
• If you have at least one table open then proceed to open & close then open & close other tables, this causes the newly opened table to walk down the screen as you continue to do this. The Editor seems to remember the position of the last table even though it is closed. It should switch back to the current table with focus as a reference.
• Is table scaling selection supposed to work on the axis values too? Target Boost Compensation (ECT) does not change temperature headings.
• View > Table Properties > Conversion window lists just plain text, will this be updated (to a JTable maybe)?
• Clicking 3D view of a map crashes RR and Java, no warning.
• In Settings the Add association doesn't seem to work on Win XP, have not tried Win 7 yet.
• If I save a ROM the Window title bar updates with the new name but none of the File & View menu items do, they still have the old name.
• If you open the Editor and then open the Logger then close the Logger and then the Editor, Java crashes. Last entry in log is "INFO [AWT-EventQueue-0] - Logger shutdown successful"

Good stuff thanks. I will work on some fixes.

• The Scaling selection font is not consistent with the other buttons and fields on the toolbar.
  Fixed. The text was set to Tahoma. This is not set so it should inherit.
• Column headings are squished on some tables but not others. See Feedback Correction Range (RPM) for an example.
  Fixed. Static text columns do not use the cell size setting.
• When viewing data in raw value display the increment/decrement values remain float rather than switch too (are they supposed to switch?)
  Fixed. This will switch to the default values for raw.
• When viewing data as raw value, display increments work on the table cell values but not decrements
  Fixed
• Cell borders, increase is blue and decrease is red (did we not switch these?)
  Fixed. You will need to update your settings but the defaults are now red for increased and blue for decreased.
• Table load error if axis element <table type="X Axis" name="" /> has a null or undefined name (the name of the table could be helpful in the message)
  Can you please post the error message text?
• If you have at least one table open then proceed to open & close then open & close other tables, this causes the newly opened table to walk down the screen as you continue to do this. The Editor seems to remember the position of the last table even though it is closed. It should switch back to the current table with focus as a reference.
  Fixed. This was using the closed table as the "current" table. This now check if the table is visible. If not it will select the first table in the list of tables.
• Is table scaling selection supposed to work on the axis values too? Target Boost Compensation (ECT) does not change temperature headings.
  No. The scaling only works on the selected "table". The headers and data are seen as different tables by the RR editor.
• View > Table Properties > Conversion window lists just plain text, will this be updated (to a JTable maybe)?
  An update would be nice. I went with text because this was easiest. I would put this in as an improvement.
• Clicking 3D view of a map crashes RR and Java, no warning.
  3D library crashing when looking openGL or something like that. This is happening in the 3rd party library and it bringing down the editor. I had this issue with remote desktop running on the laptop it worked fine. I have tried different threads but it still crashed RR.
• In Settings the Add association doesn't seem to work on Win XP, have not tried Win 7 yet.
• If I save a ROM the Window title bar updates with the new name but none of the File & View menu items do, they still have the old name.
  Could not reproduce.
• If you open the Editor and then open the Logger then close the Logger and then the Editor, Java crashes. Last entry in log is "INFO [AWT-EventQueue-0] - Logger shutdown successful"
  Could not reproduce. Did you get a stack trace or run in debug mode?

I will post an update sometime tomorrow if i get time.

10 Roms open at once with no crashes. New record.

OK, but it didn't have anything to do with any ROMs open. Just open the Editor then the Logger then close them both, no ROMs opened or Logger connection made either. I'll look some more.

No I totally get it. I was looking at the opening and closing code and found some more places to clean up the Settings and ECUEditor references. After I cleaned these up I was able to get better performance and a slightly smaller memory footprint.

I am unable to reproduce the window title bar and menu update issue as well as the open Editor, open Logger, close Logger, close Editor crash. Try the latest updates and let me know if you still see either bug. If you get the crash again go fetch the windows event log and/or the windows error report and I will take a look at that.

Are you running java 1.6 or 1.7. I think I am using 1.7 so that may make a difference on some of these. I will test again with 1.6.

I cannot find this anywhere in the code. Could this be the message? "Error loading table, " I could see how this code path would return an empty name if the axis did not have a name. In this case I could go to the parent table and grab the table name.

Also is this error showing up in a dialog box or is it in the log file?

I get this error when running in remote desktop. If I run from the laptop i do not get this error.

ERROR:
javax.media.j3d.IllegalRenderingStateException: GL_VERSION
at javax.media.j3d.NativePipeline.createNewContext(Native Method)
at javax.media.j3d.NativePipeline.createNewContext(NativePipeline.java:2691)
at javax.media.j3d.Canvas3D.createNewContext(Canvas3D.java:4799)
at javax.media.j3d.Canvas3D.createNewContext(Canvas3D.java:2351)
at javax.media.j3d.Renderer.doWork(Renderer.java:876)
at javax.media.j3d.J3dThread.run(J3dThread.java:256)

DefaultRenderingErrorListener.errorOccurred:
CONTEXT_CREATION_ERROR: Renderer: Error creating Canvas3D graphics context
graphicsDevice = Win32GraphicsDevice[screen=0]
canvas = javax.media.j3d.Canvas3D[canvas0,0,0,384x362]
Java 3D ERROR : wglGetExtensionsStringARB not support !
- The specified procedure could not be found.


Fallback to use standard ChoosePixelFormat.
Java 3D ERROR : OpenGL 1.2 or better is required (GL_VERSION=1.1)

Are you sure running across remote desktop is valid, not many users will be editing that way.
Anyway, I think it's a Java problem, running with JRE 1.7.0_25 I get this error before the JVM crash.
and no Windows Event messages logged.

If I switch back to JRE version 1.6.0_45 3D displays fine.

I found that this only happens when the Y axis name attribute is null for a 3D table definition. If the X axis is null there's no error. 2D tables seem to load fine if the axis name is null.

Agreed this feels like a java and/or 3rd party library issue. I have tried updating the J3d libraries but it still crashes. I do get a very nice stack trace and a pretty error message but it still crashes.

I will add better logging. This error can come from any part of the code so logging the stack trace will be useful for debugging purposes. What would you expect the behavior to be? Should this load the table if the name is null or empty? There is no reason we cant go with a default value of empty string, "unknown", or something like that. For now i will default this to unknown and log the error when we get in any of these error conditions.

Also could you post the Rom and definition file that is giving you this error? I would like to debug through this.