|
RomRaider
Documentation
Community
Developers
|
|
Page 1 of 1
|
[ 7 posts ] |
|
| Author |
Message |
|
merchgod
|
Post subject: increment values? Posted: Mon Jul 03, 2006 1:27 pm |
|
 |
| RomRaider Donator |
 |
Joined: Thu Mar 30, 2006 2:38 am Posts: 5336
|
|
How is the fine increment value implemented? It is a percentage of the coarse value which is in the XML as "increment"?
Also, RomRaider doesn't seem to allow increment values under 1. This is an issue with some of the float values as 1 is too large.
|
|
| Top |
|
 |
|
qoncept
|
Post subject: Posted: Mon Jul 03, 2006 1:44 pm |
|
 |
| Administrator |
 |
Joined: Fri Jan 13, 2006 4:33 pm Posts: 2079 Location: Palo, IA
|
|
The increment value is (was) what to increment the byte value by. With the latest release I fixed the UI (you can type .1 in, for example) but apparantly I forgot to fix the XML parser, too. I'll get it in the next release, which shouldn't be too long.
I don't think it'd be too much trouble to change the increment value to use real values, but there might be issues with people using older definition files. I think that probably is the best way to go, though. I'll look in to it.
I just started working on the ECU definition editor. I think its going to be a good deal of work, but it'll be really nice to have, especially for the non-Subaru guys. I also added user levels last night.
Edit: That brings up a good question.. What should I do about fine adjustment of values? With just integers, fine was increment by 1, and coarse by whatever was in the definition. Like you said, incrementing by 1 may often be too much for floats.. maybe I'll have to add another attribute in the XML? (fineincrement=".1" or something..)
_________________ - Jared
|
|
| Top |
|
 |
|
qoncept
|
Post subject: Posted: Mon Jul 03, 2006 2:27 pm |
|
 |
| Administrator |
 |
Joined: Fri Jan 13, 2006 4:33 pm Posts: 2079 Location: Palo, IA
|
|
Alright, both of these things are fixed. I'll keep working on the definition editor, but if anything else comes up I may fix/add them and release before the editor is finished.
_________________ - Jared
|
|
| Top |
|
 |
|
merchgod
|
Post subject: Posted: Mon Jul 03, 2006 3:26 pm |
|
 |
| RomRaider Donator |
 |
Joined: Thu Mar 30, 2006 2:38 am Posts: 5336
|
|
Cool. The fine increment attribute would probably work out great. Having real values for increment would also be helpful for non-floats too, as with the many conversion formulas, you could get a more accurate step. For example, if the formula is x/1.64, I could make the increment 1.64 to get a step of exactly 1.
Also, I think the user should see the actual step on the screen, not the step of the non-converted ECU data. You could run the increment value through the expression formula to show the actual change that the user will see. And what they enter in as well, if they wish to change the increment. I guess you could change the increment in the XML to be the actual increment as well, but that would cause problems for people with older definition files. Then again, as long as the newest defintion file is included with each release, it probably won't be that big of an issue.
|
|
| Top |
|
 |
|
qoncept
|
Post subject: Posted: Mon Jul 03, 2006 4:27 pm |
|
 |
| Administrator |
 |
Joined: Fri Jan 13, 2006 4:33 pm Posts: 2079 Location: Palo, IA
|
Done 
_________________ - Jared
|
|
| Top |
|
 |
|
merchgod
|
Post subject: Posted: Mon Jul 03, 2006 5:02 pm |
|
 |
| RomRaider Donator |
 |
Joined: Thu Mar 30, 2006 2:38 am Posts: 5336
|
qoncept wrote: Done 
Wow, that was fast.
Will the XML increment be the same ECU increment or the actual post-conversion increment? Did you add the fineincrement attribute?
Thanks
|
|
| Top |
|
 |
|
qoncept
|
Post subject: Posted: Mon Jul 03, 2006 5:29 pm |
|
 |
| Administrator |
 |
Joined: Fri Jan 13, 2006 4:33 pm Posts: 2079 Location: Palo, IA
|
|
Ok.. if you set coarse or fine increment to .16, it'll increase the value the user sees by .16.
I've removed "increment" from the XML and replaced it with "fineincrement" and "coarseincrement". Fine we default to 1 and coarse to 2 if they are not set. Also, if the parser finds the attribute "increment," it'll assume it means coarse, so it'll be backwards compatible with old defs. This revision will probably be released next week.
_________________ - Jared
|
|
| Top |
|
 |
|
Page 1 of 1
|
[ 7 posts ] |
|
Who is online |
Users browsing this forum: No registered users and 26 guests |
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot post attachments in this forum
|
|