RomRaider Logo

RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Tue Dec 23, 2025 3:45 pm

All times are UTC - 5 hours [ DST ]





Post new topic Reply to topic  [ 8 posts ] 
Author Message
 Post subject: Logger fixes needed for 32bit SD ROM support
PostPosted: Mon Sep 16, 2013 10:55 pm 
Offline
RomRaider Developer

Joined: Wed May 20, 2009 9:49 pm
Posts: 7314
Location: Canada eh!
STI2NR wrote:
Do you understand what I am saying?
No not really...

Here's how it is suppose to work...
Logger starts up and checks the definition file version (i.e.: <logger version="185"> ). If the version is not found or is too old you get a warning. There's two ways to fix this 1) add the version string to the logger.xml you are using or 2) copy the SD parameters info to the most current logger.xml and add the unique SD ROM ECU ID to the XML. How do I add it you ask? Find/replace the non-SD ECU ID with the SD ECU ID.

Now the Logger has a good def and does not complain about the version. All the SD parameters are there since you just added them. With that the Logger connects to the ECU and gets the init string. From within the init string the Logger parses out the ECU ID. With the ECU ID the Logger can now filter the logger.xml and present to you all the compatible parameters to log.

If you get a CAL ID: unknown then you don't have an ECU def defined in your Editor Definition Manager. In the RomRaider definition for your ROM your need these two things, 1) the ECU ID that you are using and the CAL ID that it cross references to.

In the sample I posted above you can adjust them as required for your SD ROM. Once you do this then point the Editor Def Manager at your new RomRaider def file (Note: EcuFlash def files will NOT work as they don't contain all the required info for RomRaider). The next time you start the Logger, if all cross references correctly then your should get an ECU & CAL ID in the Logger window. If not then go back and fix-up the defs as I describe above.

Once you get the ECU ID & CAL ID to show up correctly AND you are using a def version of 155 or higher (which contains DTC info for the DTC reader to work) then you should be able to use the Learning Table View feature in the Logger tools.

Give it a try and if you still can't make it work then post up the files you are using and a copy of the rr_system.log (with TRACE level detail) in a new thread so we can see what's going on under the hood.


Top
 Profile  
 
 Post subject: Re: Learning View v1.0 RC3
PostPosted: Tue Sep 17, 2013 1:34 pm 
Offline
Experienced
User avatar

Joined: Thu Jul 23, 2009 1:46 pm
Posts: 863
STI2NR wrote:
dschultz wrote:
STI2NR wrote:
Do you understand what I am saying?
No not really...

Here's how it is suppose to work...
Logger starts up and checks the definition file version (i.e.: <logger version="185"> ). If the version is not found or is too old you get a warning. There's two ways to fix this 1) add the version string to the logger.xml you are using or 2) copy the SD parameters info to the most current logger.xml and add the unique SD ROM ECU ID to the XML. How do I add it you ask? Find/replace the non-SD ECU ID with the SD ECU ID.

Now the Logger has a good def and does not complain about the version. All the SD parameters are there since you just added them. With that the Logger connects to the ECU and gets the init string. From within the init string the Logger parses out the ECU ID. With the ECU ID the Logger can now filter the logger.xml and present to you all the compatible parameters to log.

If you get a CAL ID: unknown then you don't have an ECU def defined in your Editor Definition Manager. In the RomRaider definition for your ROM your need these two things, 1) the ECU ID that you are using and the CAL ID that it cross references to.

In the sample I posted above you can adjust them as required for your SD ROM. Once you do this then point the Editor Def Manager at your new RomRaider def file (Note: EcuFlash def files will NOT work as they don't contain all the required info for RomRaider). The next time you start the Logger, if all cross references correctly then your should get an ECU & CAL ID in the Logger window. If not then go back and fix-up the defs as I describe above.

Once you get the ECU ID & CAL ID to show up correctly AND you are using a def version of 155 or higher (which contains DTC info for the DTC reader to work) then you should be able to use the Learning Table View feature in the Logger tools.

Give it a try and if you still can't make it work then post up the files you are using and a copy of the rr_system.log (with TRACE level detail) in a new thread so we can see what's going on under the hood.


This is one of the most helpful posts I have ever seen on RR. When I get back to my tuning this weekend I will sit down and go through each step on all 3 of my logging netbooks. I want to be up to date with everything so it all works the way it should.

Thank you for taking the time to walk a "non-it" guy through the steps so that I can understand and accomplish them. I will test it this weekend and get back to you.


I've confirmed that 0.5.7 has broken all of the SD defs. I'll see if I can get you a fix before the weekend. It's ridiculous for an end user to have to go through all this to fix a bug caused by lack of communication between the developers.

_________________
Please do not send me support questions via PM, use the forum instead!


Top
 Profile  
 
 Post subject: Re: Learning View v1.0 RC3
PostPosted: Tue Sep 17, 2013 5:12 pm 
Offline
RomRaider Developer

Joined: Wed May 20, 2009 9:49 pm
Posts: 7314
Location: Canada eh!
Merp wrote:
I've confirmed that 0.5.7 has broken all of the SD defs. I'll see if I can get you a fix before the weekend. It's ridiculous for an end user to have to go through all this to fix a bug caused by lack of communication between the developers.
Interesting as I just described how RomRaider has worked from the very beginning. How have SD ROMs changed to not be compatible with it?
The addition of DTC reading is purely SSM so that should not change anything.
The addition of Learning Table Values only relies on ECU ID -> CAL ID -> RomRaider Editor def for the CAL ID. This hasn't changed either, only enhanced to support LTV.

Please show me where it's breaking down.


Top
 Profile  
 
 Post subject: Re: Learning View v1.0 RC3
PostPosted: Tue Sep 17, 2013 11:45 pm 
Offline
RomRaider Developer

Joined: Wed May 20, 2009 9:49 pm
Posts: 7314
Location: Canada eh!
STI2NR wrote:
This is one of the most helpful posts I have ever seen on RR. When I get back to my tuning this weekend I will sit down and go through each step on all 3 of my logging netbooks. I want to be up to date with everything so it all works the way it should.

Thank you for taking the time to walk a "non-it" guy through the steps so that I can understand and accomplish them. I will test it this weekend and get back to you.

I looked this over and confirmed that the steps I outlined above will allow you to use all the functions of the latest version of RomRaider Logger. You just need to build your own RomRaider style ECU def as none is provided as part of the SD patch process.
Another anomaly I noticed is that the logger defs provided with the SD patches have <ecuparam> elements defined with missing <ecu id="##########"> elements. This violates the DTD check as at least one <ecu> element must be present. It will also through an exception when the def is parsed upon loading.

Here's a working set for a patched A2ZJB11J ROM so you can follow along.


You do not have the required permissions to view the files attached to this post.


Top
 Profile  
 
 Post subject: Re: Learning View for 32bit SD ROMS
PostPosted: Wed Sep 18, 2013 1:40 am 
Offline
Experienced
User avatar

Joined: Thu Jul 23, 2009 1:46 pm
Posts: 863
Yep, ecuparams with no ecu element throw an exception that barfs the whole definition since https://github.com/RomRaider/RomRaider/ ... 6e4f578b75

_________________
Please do not send me support questions via PM, use the forum instead!


Top
 Profile  
 
 Post subject: Re: Learning View for 32bit SD ROMS
PostPosted: Wed Sep 18, 2013 9:41 am 
Offline
RomRaider Developer

Joined: Wed May 20, 2009 9:49 pm
Posts: 7314
Location: Canada eh!
Merp wrote:
Yep, ecuparams with no ecu element throw an exception that barfs the whole definition since https://github.com/RomRaider/RomRaider/ ... 6e4f578b75

Yes EcuAddressImpl.java was changed back in May to support non-contiguous SSM addresses for multi-byte parameters for TCU queries by adding an additional function. The functions check for a null address and throw an exception.

The simplest solution at the moment is to delete all <ecuparam > elements that have no defined <ecu> element from the logger def file as per the DTD.
Using the XML Tools plugin of Notepad++, it's easy to validate, locate and correct XML errors.


Top
 Profile  
 
 Post subject: Re: Learning View for 32bit SD ROMS
PostPosted: Wed Sep 18, 2013 10:24 am 
Offline
Experienced
User avatar

Joined: Thu Jul 23, 2009 1:46 pm
Posts: 863
dschultz wrote:
Merp wrote:
Yep, ecuparams with no ecu element throw an exception that barfs the whole definition since https://github.com/RomRaider/RomRaider/ ... 6e4f578b75

Yes EcuAddressImpl.java was changed back in May to support non-contiguous SSM addresses for multi-byte parameters for TCU queries by adding an additional function. The functions check for a null address and throw an exception.

The simplest solution at the moment is to delete all <ecuparam > elements that have no defined <ecu> element from the logger def file as per the DTD.
Using the XML Tools plugin of Notepad++, it's easy to validate, locate and correct XML errors.


It's much simpler to add a well directed try catch to preserve the compatibility with files that work perfectly fine aside from adhering to a previously unenforced pedantic standard belonging to an atrocious xml schema that should be binned asap anyway.

_________________
Please do not send me support questions via PM, use the forum instead!


Top
 Profile  
 
 Post subject: Re: Learning View for 32bit SD ROMS
PostPosted: Wed Sep 18, 2013 1:17 pm 
Offline
RomRaider Developer

Joined: Wed May 20, 2009 9:49 pm
Posts: 7314
Location: Canada eh!
Sure we can add additional error checking to handle malformed XML data. I'll add it to the list for the next update.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 8 posts ] 

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl