RomRaider Logo

RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Tue Dec 23, 2025 9:16 am

All times are UTC - 5 hours [ DST ]





Post new topic Reply to topic  [ 355 posts ]  Go to page Previous  1 ... 17, 18, 19, 20, 21, 22, 23, 24  Next
Author Message
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Thu Jun 13, 2019 10:09 am 
Offline
RomRaider Donator

Joined: Tue Apr 29, 2014 12:48 am
Posts: 946
yes we need the accelerator maps/requested torque maps relation with throttle opening angle table.

_________________
RomRaid!


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sun Jul 26, 2020 8:37 pm 
Offline
RomRaider Donator

Joined: Tue Jan 28, 2014 10:48 am
Posts: 120
Getting my feet wet with Java by trying to add some features into MAF Scaling myself.

While I was in there, I found a bug/typo for LogStats.java, where Standard Deviation doesn't work. This is because statistics array defines "Standard Deviation", but when it's actually used in "private Statistics getStatId() {" the condition looks for "Std Devn" variable instead:

Code:
        if ("Std Devn".equals(name))
            return Statistics.STDDEV;
        return Statistics.MEAN;


Next the Cell Hit Minimum Count window covers up the log names. It could be sized down to be 5-6 characters tops probably. I tried to size it down by modifying the numbers, to no avail, though setting hitCountTextBox to false did work, but I'm sure that breaks something else?
Code:
            addLabel(2, 1, "Cell Min Count");
            hitCountTextBox = addTextField(2, 2, 3, NumberFormat.getIntegerInstance(), false);


Lastly, I tried to add a new SUM option, where it would sum up all the values in the specific cell. This would mostly be useful for seeing how many knock events happened or how many times AC, or Rad Fans, kicked on. Mostly for binary items. I tried various ways to call the sum function to no avail, I guess Utils or Collections don't have it defined.


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Mon Jul 27, 2020 4:10 pm 
Offline
Experienced

Joined: Sun Oct 27, 2013 8:28 pm
Posts: 149
covertrussian wrote:
Getting my feet wet with Java by trying to add some features into MAF Scaling myself.

While I was in there, I found a bug/typo for LogStats.java, where Standard Deviation doesn't work. This is because statistics array defines "Standard Deviation", but when it's actually used in "private Statistics getStatId() {" the condition looks for "Std Devn" variable instead:

Code:
        if ("Std Devn".equals(name))
            return Statistics.STDDEV;
        return Statistics.MEAN;


Next the Cell Hit Minimum Count window covers up the log names. It could be sized down to be 5-6 characters tops probably. I tried to size it down by modifying the numbers, to no avail, though setting hitCountTextBox to false did work, but I'm sure that breaks something else?
Code:
            addLabel(2, 1, "Cell Min Count");
            hitCountTextBox = addTextField(2, 2, 3, NumberFormat.getIntegerInstance(), false);


Lastly, I tried to add a new SUM option, where it would sum up all the values in the specific cell. This would mostly be useful for seeing how many knock events happened or how many times AC, or Rad Fans, kicked on. Mostly for binary items. I tried various ways to call the sum function to no avail, I guess Utils or Collections don't have it defined.


good catch on Std Devn, I recall renaming it for the screen at some point but forgot the name value was used for logical code.

As for Cell Hit Minimum Count, I'm not sure what exactly you're talking about, screen shot would help. If you simply change the name from 'Cell Hit Minimum Count' to 'Cell Min Count' the you should get a bit of extra space, no other changes are needed. Now if you think you could get an extra space by shorting the actual display box for Cell Hit Minimum Count - then no, you wouldn't. That box is expanded to fill the same length as both axis drop down boxes. You would need to learn how GridBagLayout in Java works and how the current layout is done. All in all though I believe the minimum expected screen resolution is expected to be 600 on width. Perhpas you're loading too many log files - again, that was rather a convenience function to avoid manual files concatenation, the screen never meant to guaranty to display all log files names. another words if you load 2000 log files, if it were allowed and your screen resolution is small then all you'd see would be just those files names.

Again, I'm not sure what exactly you're talking about with sum, or rather what your expectation is. If I got your idea correctly you'd need to keep and matrix of the same size as the displayed table and manually calculate sum for each cell as every row from log is being processed. Then somehow trigger to display your sum somewhere.

I'll make the change to fix standard deviation and will shorten the name.

PS cut the new Release v2.5.2


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sat Aug 01, 2020 2:57 pm 
Offline
RomRaider Donator

Joined: Tue Jan 28, 2014 10:48 am
Posts: 120
Thanks for the fix!

Here's the screenshot with the log name. I tend to use very detailed log names, I think left aligning the filename with Data/Stats dropdowns would do (beginning part of file name matters more then ending).
Attachment:
Log Name Cut Off.png
Log Name Cut Off.png [ 72.22 KiB | Viewed 7649 times ]


As for SUM, the only use case I can really think of is counting how many times AC was on in the cell, or any other binary field. Not sure it's all that beneficial though, right now I sum up the data using excel :D


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sat Aug 01, 2020 6:49 pm 
Offline
Experienced

Joined: Sun Oct 27, 2013 8:28 pm
Posts: 149
covertrussian wrote:
Thanks for the fix!

Here's the screenshot with the log name. I tend to use very detailed log names, I think left aligning the filename with Data/Stats dropdowns would do (beginning part of file name matters more then ending).


ah, ok. I changed it, updated the new rel patch


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sat Aug 01, 2020 7:47 pm 
Offline
RomRaider Donator

Joined: Tue Jan 28, 2014 10:48 am
Posts: 120
Works like a charm, thank you very much!


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Wed Aug 05, 2020 12:34 pm 
Offline
Newbie

Joined: Sun Jan 06, 2019 6:42 pm
Posts: 39
Location: South Wales, UK
Hello Vgi,

Brought down the latest rev of your software, 2.5.3, and whilst working my way along it, it threw this error up. See Image.

My question is this a Java error or is it in the log file make up.

The log has two extra coloums added, if this may make a difference.

If you have a spare moment, I would welcome your opinion on it.

Mark...


Attachments:
File comment: Maf OL/CL error
Error-1.png
Error-1.png [ 15.05 KiB | Viewed 7615 times ]

_________________
MY04 Impreza WRX (EDM)
Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Wed Aug 05, 2020 2:20 pm 
Offline
Experienced

Joined: Sun Oct 27, 2013 8:28 pm
Posts: 149
Mark_Bowley wrote:
Hello Vgi,

Brought down the latest rev of your software, 2.5.3, and whilst working my way along it, it threw this error up. See Image.

My question is this a Java error or is it in the log file make up.

The log has two extra coloums added, if this may make a difference.

If you have a spare moment, I would welcome your opinion on it.

Mark...


Mark, it's hard to say from this screenshot. Pls PM me a full screenshot of the program and your log file.


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Thu Aug 06, 2020 8:29 am 
Offline
Newbie

Joined: Sun Jan 06, 2019 6:42 pm
Posts: 39
Location: South Wales, UK
Vgi,

Thanks for your quick response, I will generate a new log file over the next few days, just to eliminate a possible log file error, then contact you with the screenshots and logs.

Mark...

As an update to this, it seems the log was at fault. I generated a new log and now the error has disappeared, so probably a corruption of the log file, so happy days are hear again.

_________________
MY04 Impreza WRX (EDM)


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Tue Aug 11, 2020 2:48 am 
Offline
RomRaider Donator

Joined: Tue Apr 29, 2014 12:48 am
Posts: 946
welaish wrote:
yes we need the accelerator maps/requested torque maps relation with throttle opening angle table.


VGI no chance to add a new tab for the throttle maps?

_________________
RomRaid!


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sat Aug 15, 2020 12:53 am 
Offline
Experienced

Joined: Sun Oct 27, 2013 8:28 pm
Posts: 149
welaish wrote:
welaish wrote:
yes we need the accelerator maps/requested torque maps relation with throttle opening angle table.


VGI no chance to add a new tab for the throttle maps?


I just cut a new release. Please let me know if you find any bugs or some changes need to be made.


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sun Aug 16, 2020 1:42 am 
Offline
RomRaider Donator

Joined: Tue Apr 29, 2014 12:48 am
Posts: 946
vgi wrote:

I just cut a new release. Please let me know if you find any bugs or some changes need to be made.



thank you it works as expected.

_________________
RomRaid!


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sun Aug 16, 2020 10:20 am 
Offline
Experienced

Joined: Sun Oct 27, 2013 8:28 pm
Posts: 149
welaish wrote:
vgi wrote:

I just cut a new release. Please let me know if you find any bugs or some changes need to be made.



thank you it works as expected.



sorry, there was a bug. I added calc cells highlighting, merged and re-released the version. So pls get again the v2.6.0 from 8/16/2020


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sun Sep 13, 2020 4:46 am 
Offline
Newbie

Joined: Sun Apr 17, 2016 4:27 pm
Posts: 24
vgi, is there any possibility to implement reverse calculation logic for throttle maps, something like this:
1. Choose the map, which should be calculated (any of three, the "Reqd torque - RPM" can be used as is in the logic now), for example "Target throttle plate position"
2. Fill the other two ("RT - Acc pedal" and "Throttle plate vs Acc pedal")
3. The result should be calculated and filled in "Target throttle plate position"


Top
 Profile  
 
 Post subject: Re: UTILITY: CL/WOT MAF Scaling | Log View/Stats | Load/IAT
PostPosted: Sun Sep 13, 2020 10:23 am 
Offline
Experienced

Joined: Sun Oct 27, 2013 8:28 pm
Posts: 149
srg123 wrote:
vgi, is there any possibility to implement reverse calculation logic for throttle maps, something like this:
1. Choose the map, which should be calculated (any of three, the "Reqd torque - RPM" can be used as is in the logic now), for example "Target throttle plate position"
2. Fill the other two ("RT - Acc pedal" and "Throttle plate vs Acc pedal")
3. The result should be calculated and filled in "Target throttle plate position"


The calculation has certain flow and can’t be reversed just like it’s not possible to revert calculation of the 2 parameter addition of resulting 5: there could be 0+5, 1+4, 2+3 (considering whole numbers only)


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 355 posts ]  Go to page Previous  1 ... 17, 18, 19, 20, 21, 22, 23, 24  Next

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl