RomRaider Logo

RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Tue Dec 23, 2025 11:11 am

All times are UTC - 5 hours [ DST ]





Post new topic Reply to topic  [ 159 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6 ... 11  Next
Author Message
 Post subject: Re: Timing Editor
PostPosted: Tue Feb 24, 2009 4:52 am 
Offline
Experienced

Joined: Sun Jun 03, 2007 12:08 pm
Posts: 224
Location: Gig Harbor, WA
I found that if I pasted a copy of a faked advance table that fit the header columns it worked great for my use. it is an extra step but the time savings is still great.

Thanks again for the great tool!


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Tue Feb 24, 2009 6:37 pm 
Offline
Experienced
User avatar

Joined: Mon Apr 30, 2007 8:02 pm
Posts: 521
Thanks NSFW

_________________
05 LGT (ST and OS tuning) AVO380/TMIC/header/TBE/alky/AEM CAI


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Wed Feb 25, 2009 4:23 am 
Offline
Moderator

Joined: Wed Nov 22, 2006 10:23 pm
Posts: 2565
Version 6 has undo/redo. (I left version 5 there just in case.)

It only does undo/redo for changes to individual cells. I have a some ideas about undo/redo for smoothing and paste as well, but no promises.

_________________
2005 Legacy GT w/ ATP 3076, IWG, MBC, BCS, BC 272, LC, FFS, OMG
Please don't send questions via PM. Post a thread and send me a link to it instead. Thanks!


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Thu Feb 26, 2009 5:29 am 
Offline
Moderator

Joined: Wed Nov 22, 2006 10:23 pm
Posts: 2565
Version 7 has colors, and fixes a bug in the undo/redo stuff.

_________________
2005 Legacy GT w/ ATP 3076, IWG, MBC, BCS, BC 272, LC, FFS, OMG
Please don't send questions via PM. Post a thread and send me a link to it instead. Thanks!


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Thu Feb 26, 2009 8:40 am 
Offline
RomRaider Donator
User avatar

Joined: Thu Aug 09, 2007 10:40 am
Posts: 211
Location: Colorado
Ack! First crash of this program... loaded fine but crashed when pasting in base timing. Dang, and I over-wrote my version 5. Here's the error:

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at NSFW.TimingEditor.Util.GetMinMax(ITable table, Double& min, Double& max)
at NSFW.TimingEditor.Util.ColorTable(DataGridView dataGridView, ITable table, Int32 selectedX, Int32 selectedY)
at NSFW.TimingEditor.TimingForm.dataGrid_CellMouseEnter(Object sender, DataGridViewCellEventArgs e)
at System.Windows.Forms.DataGridView.OnCellMouseEnter(DataGridViewCellEventArgs e)
at System.Windows.Forms.DataGridView.UpdateMouseEnteredCell(HitTestInfo hti, MouseEventArgs e)
at System.Windows.Forms.DataGridView.OnMouseMove(MouseEventArgs e)
at System.Windows.Forms.Control.WmMouseMove(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.DataGridView.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.3082 (QFE.050727-3000)
CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
TimingEditor
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0
CodeBase: file:///D:/Legacy%20GT/Programs/TimingEditor.exe
----------------------------------------
System.Windows.Forms
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.3053 (netfxsp.050727-3000)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.3053 (netfxsp.050727-3000)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.3053 (netfxsp.050727-3000)
CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
<system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

_________________
'05 LGT, BNR68+E85


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Thu Feb 26, 2009 8:41 am 
Offline
RomRaider Donator
User avatar

Joined: Thu Aug 09, 2007 10:40 am
Posts: 211
Location: Colorado
Just re-ran the program and it worked fine... pretty!

_________________
'05 LGT, BNR68+E85


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Thu Feb 26, 2009 2:35 pm 
Offline
Moderator

Joined: Wed Nov 22, 2006 10:23 pm
Posts: 2565
Version 8 fixes that bug, and it now colors higher values yellow instead of red (pink).

_________________
2005 Legacy GT w/ ATP 3076, IWG, MBC, BCS, BC 272, LC, FFS, OMG
Please don't send questions via PM. Post a thread and send me a link to it instead. Thanks!


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Fri Feb 27, 2009 9:40 am 
Offline
Newbie

Joined: Wed Mar 21, 2007 10:58 am
Posts: 38
Location: Philadelphia
any chance you could bind ctrl+z and ctrl+y to undo/redo respectively? also how about making a listener for the smooth function for ctrl+s or alt+s? just makes working on the table a bit easier when you don't have to keep moving to the upper left part of the table? also could adding in a whole row / column selector be possible, like when you click on one of the rpm ranges it'll highlight that entire row?

also now sure if this was answered but what language is this written in?

edit: nm it seems you need the .NET framework so i'm assuming it's either VB or C#?

_________________
2007 Impreza 2.5i M/T


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Sat Feb 28, 2009 3:18 am 
Offline
Moderator

Joined: Wed Nov 22, 2006 10:23 pm
Posts: 2565
Version 9 adds hotkeys for undo/redo. They'll only work while the grid has focus, but I figure that'll be the case most of the time.

It just occurred to me that it might be pretty easy to make them work no matter which control has focus. But I'm going to bed now. :)

It's C#. I'll post the source after a few more updates.

_________________
2005 Legacy GT w/ ATP 3076, IWG, MBC, BCS, BC 272, LC, FFS, OMG
Please don't send questions via PM. Post a thread and send me a link to it instead. Thanks!


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Sat Feb 28, 2009 5:11 pm 
Offline
Experienced
User avatar

Joined: Tue Feb 12, 2008 11:00 pm
Posts: 153
Good stuff!

_________________
06 Wrx Wagon 2.3 longrod in the works


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Sat Feb 28, 2009 5:29 pm 
Offline
Experienced
User avatar

Joined: Mon Apr 30, 2007 8:02 pm
Posts: 521
tell me (not near as computer literate as you) what you want from ST so that you can get it to work here as well.

_________________
05 LGT (ST and OS tuning) AVO380/TMIC/header/TBE/alky/AEM CAI


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Sat Feb 28, 2009 10:27 pm 
Offline
Moderator

Joined: Wed Nov 22, 2006 10:23 pm
Posts: 2565
And I've never actually seen ST or ATR so you might need to bear with me a bit... Hopefully Cobb's software will copy the table in a way that can be pasted as text. First, how to copy a table from Cobb's software? I'm guessing there's a menu item, or maybe a hotkey - try CTRL-C, and if that doesn't work try CTRL-Insert. If there's no way to copy, then we're stuck. If there is a way to copy:

Open your base timing table.
Copy it.
Post a reply to this thread, and press CTRL-V to paste the table.
Repeat with your advance timing table.

Then I'll try to teach my utility to read what you've pasted.

_________________
2005 Legacy GT w/ ATP 3076, IWG, MBC, BCS, BC 272, LC, FFS, OMG
Please don't send questions via PM. Post a thread and send me a link to it instead. Thanks!


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Sun Mar 01, 2009 3:59 am 
Offline
Experienced

Joined: Sun Jun 03, 2007 12:08 pm
Posts: 224
Location: Gig Harbor, WA
I have been using this program the last couple days on some tunes I am working on. It works great and it has allowed me to much more quickly build timing tables and find problem spots.

It would help me a ton if there was a way for this to deal with tables of different size. I wind up taking quite a few additional steps to make it happen, this includes opening two maps.

Thanks again for the helpful tool!

Josh


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Sun Mar 01, 2009 2:55 pm 
Offline
Moderator

Joined: Wed Nov 22, 2006 10:23 pm
Posts: 2565
I tried to use it to view a WRX tune posted in one of the other forums here and saw what you mean. For that particular case, all that I'd need to do is make it easy to add extra columns, since the advance table looked just like the base timing table but without two low-load columns.

If that's the same thing you're running into, then I could probably make it easier to work with tables like that. Basically, if the advance table is smaller than the base table, and all of the advance table's columns are present in the base table, then I can look into adding 'fake' columns for low loads.

However, the general problem of mismatched tables would be a lot harder to solve, I'm not even going to try. If the column headers don't match up for other reasons (like, one table extends to a higher load than the other, or has an area where column headers have been revised to allow finer adjustments), I should have it give an error message rather than even pretending to work... right now it will actually allow that, but the results aren't going to make sense.

_________________
2005 Legacy GT w/ ATP 3076, IWG, MBC, BCS, BC 272, LC, FFS, OMG
Please don't send questions via PM. Post a thread and send me a link to it instead. Thanks!


Top
 Profile  
 
 Post subject: Re: Timing Editor
PostPosted: Sun Mar 01, 2009 4:18 pm 
Offline
Experienced

Joined: Sun Jun 03, 2007 12:08 pm
Posts: 224
Location: Gig Harbor, WA
NSFW wrote:
If that's the same thing you're running into, then I could probably make it easier to work with tables like that. Basically, if the advance table is smaller than the base table, and all of the advance table's columns are present in the base table, then I can look into adding 'fake' columns for low loads.

However, the general problem of mismatched tables would be a lot harder to solve, I'm not even going to try. If the column headers don't match up for other reasons (like, one table extends to a higher load than the other, or has an area where column headers have been revised to allow finer adjustments), I should have it give an error message rather than even pretending to work... right now it will actually allow that, but the results aren't going to make sense.


Just being able to add low load columns would be perfect. I have been doing this in RR (with a rom I saved as "timing editor helper" )but it is just a hassle. I will say that this is WAY better than what I was doing before either way!

I agree that you should have the error message as anything else could result in less than desireable results.

I was having some trouble with the version 9 last night. I will see if I can replicate it and post up the error message and log. It may have just been me though, it was late.

Josh


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 159 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6 ... 11  Next

All times are UTC - 5 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl