RomRaider

Hmm. I just noticed in the first thread the above quote from eminehart. I'm wondering what he found and if that could be found again? Perhaps there is a table per gear or 2 per SI-Drive mode?

I think I've found them for you, but want to verify in IDA.

Yeah, found them. There's a table per gear, and they are part of the requested torque routine.

In sequence, here are the addresses - uint16 base, 0.007815 (requestedTorqueRawEcuValue). I've had a long day, so too tired and lazy to code them into an XML for you Address in red is x axis, in green is table value.

ROM:000A7474 Table_Per_Gear_Requested_Torque_1:.data.l h'100800 ; DATA XREF: sub_BD86C+1Co
ROM:000A7474 ; sub_BD8FC:off_BD9ECo
ROM:000A7478 .data.l flt_DB994
ROM:000A747C .data.l word_DB9D4
ROM:000A7480 .float 0.0078125
ROM:000A7484 .float 0.0
ROM:000A7488 Table_Per_Gear_Requested_Torque_2:.data.l h'100800 ; DATA XREF: sub_BE1F0+8Ao
ROM:000A7488 ; sub_BE1F0:off_BE410o
ROM:000A748C .data.l flt_DB9F4
ROM:000A7490 .data.l word_DBA34
ROM:000A7494 .float 0.0078125
ROM:000A7498 .float 0.0
ROM:000A749C Table_Per_Gear_Requested_Torque_3:.data.l h'100800 ; DATA XREF: sub_BE1F0+94o
ROM:000A749C ; sub_BE1F0:off_BE418o
ROM:000A74A0 .data.l flt_DBA54
ROM:000A74A4 .data.l flt_DBA94
ROM:000A74A8 .float 0.0078125
ROM:000A74AC .float 0.0
ROM:000A74B0 Table_Per_Gear_Requested_Torque_4:.data.l h'100800 ; DATA XREF: sub_BE9DA+36o
ROM:000A74B0 ; ROM:off_BEB3Co
ROM:000A74B4 .data.l flt_DBAB4
ROM:000A74B8 .data.l flt_DBAF4
ROM:000A74BC .float 0.0078125
ROM:000A74C0 .float 0.0
ROM:000A74C4 Table_Per_Gear_Requested_Torque_5_6:.data.l h'100800 ; DATA XREF: sub_BE9DA+3Ao
ROM:000A74C4 ; ROM:off_BEB40o
ROM:000A74C8 .data.l flt_DBB14
ROM:000A74CC .data.l flt_DBB54
ROM:000A74D0 .float 0.0078125
ROM:000A74D4 .float 0.0

Ok - here's the xml definition for Ecuflash - just plug this in at the beginning (or end) of the A2TB001L.xml

Thanks for finding this! Unfortunately I don't think it's quite working out for me. I set RT as follows:

1st 350
2nd 340
3rd 330
4th 320
5&6th 310

I took a log of 2nd, 3rd and 4th gear pulls and all are gears are hitting 340. Attached logs, xml and map. Did I screw something up?

There might be a static limit set in the code, I did see some float values in the vicinity - l'll have a look to see if I can find anything.

On closer examination, the tables are not used adjacently in the code, but through a a very convoluted set of code relating to the accel pedal opening / requested torque etc.

I actually think these tables are correlated with the SI drive mode, not gears. In particular, it looks (at a cursory glance!) that tables 2 and 3 relate to S# and S mode - I assume that you did the pulls in S# mode? Hence the 340 limit. I'm betting that if you did a pull in S mode, you would hit a limit of 330. If you want to test my theory, set table 2 to a higher setting, and see if it caps at that in S# mode, also try to see what the cap is in S mode. I would set these back to the stock values of 500 afterwards.

What I did see is that further on the code, there are 2 cells tables that that provide a sliding scale for requested torque based on RPM, also relating to what I think is the SI mode - from 0-4000 rpms, and the one from 0-400, the other 0-200.

I have, however found a set of 2D tables that like the STI, seem to relate to gear 1 and 6. If you log Ram location FFFF701C, I think you'll find it's the uint8 (1byte) current gear parameter.

The one table is:

Y Axis DBB94 (rawecu value float)
Z Value DBB9C (rawecu value float)

and the values are set at 500

The other 2 tables are :

Y Axis C6BBC (rawecu value float)
Z Value C6BC4 (rawecu value float)

and

Y Axis C6BBC (rawecu value float)
Z Value C6BC4 (rawecu value float)

and the values are set at 100 to 600

Just a caveat - unfortunately, I do not have a a good deal of this rom disassembled like mine, and the code in this location if complex, so proceed with caution...

What I'm thinking is that unlike the other roms with a 6 gear / RPM 3D tables, this rom splits the limits into two tables, one with RPMs and one with gears. But that's just conjecture.

Thanks for the continued help. I did do all 3 logs in S mode. I mainly only use S so I didn't think to do the pulls in S#. Should I return all these values to 500 and then try the other 2d table?

Ok - in that case Table 2 is likely S mode and Table 3 is S#.

I would return to stock (otherwise you're capping the maximum torque for all the SI modes), and try the other tables - please remember that these are experimental, so there's always a risk!

I will return the other values to stock and look over the other 3 tables and see if I can make sense of them. Unfortunately I'm not entirely sure how to translate those values to xml.

Give me a couple of minutes, I'm in and out of meetings, and I'll post up the definitions for you.

Here are the definitions:



And here's what they look like. I would start with the 500 / 500 table.

Thanks again!

Returned all previous changes to stock and added the 5 new tables. As suggested, I only messed with "newtable3" changing it from 500/500 to 350/300. The result is 350 in 1st, 340 in 2nd, 330 in 3rd, 320 in 4th and 310 in 5th. Exactly what I was trying to accomplish! Thanks so much for the help on this!

Bingo!

Excellent, I'm glad it was the right tables. What is it about the Legacy's that the code is always so bloody different I'm sure NSFW will jump in here