RomRaider

If I remembered correct, most of my last updates are related to kernel updates, combining can kernel codes, modified kernel makefiles (kerbels are in different repo), added eeprom functionality to them and made changes to modules to use them. All for SH kernels/modules. There's still some work to make atleast eeprom functionality to work right on some models.

As it has been a while wheen last time done anything, I should take a look at the code to be sure. But if anything buzzling comes to mind, just shoot me a message. I'm sure you find losts of 'wtf' moments when reading my code

Good plan. Done. Thanks!

I will pause creating new modules until we have a sync'd code base.

I'm stuck a little bit. That's because I know hardware bad. As far as I understand, syncing breaks new TCU modules that work over ISO15765, right?

Heres serial_port_actions.cpp diff



It appears that when using ISO15765 first 4 bytes are removed from all received data. Of course this will break everything. But if I return how it was, it will break ECU modules that work over ISO15765 that MiikaS changed. There's too many changes done and I hardly understand what and why was done.

Could you please tell me what modules works over ISO15765? As far as I understand it's eeprom_ecu_subaru_denso_can, flash_ecu_subaru_denso_sh7058_can and flash_ecu_subaru_denso_sh7058_can_diesel only.

I'm stuck a little bit. That's because I know hardware bad. As far as I understand, syncing breaks new TCU modules that work over ISO15765, right?

Heres serial_port_actions.cpp diff



It appears that when using ISO15765 first 4 bytes are removed from all received data. Of course this will break everything. But if I return how it was, it will break ECU modules that work over ISO15765 that MiikaS changed. There's too many changes done and I hardly understand what and why was done.

Could you please tell me what modules works over ISO15765? As far as I understand it's eeprom_ecu_subaru_denso_can, flash_ecu_subaru_denso_sh7058_can and flash_ecu_subaru_denso_sh7058_can_diesel only.

I think it's all CAN modules.
eeprom_ecu_subaru_denso_can.cpp
flash_ecu_subaru_denso_sh7xxx_can_.cpp
flash_ecu_subaru_denso_sh705x_can.cpp
flash_ecu_subaru_denso_sh7058_can.cpp
flash_ecu_subaru_denso_sh7058_can_diesel.cpp

Need to replace all things like this:

To:


And so on with all questions about received data.

Not only TCU, but all TCU/ECU Hitachi/Melco CAN modules.

Not sure if all. I'll track them down by variable





Yeah, you're right! I need to go through every changed file, it will take a time.



Fix them would be easy - I'll revert serial_port_actions.cpp changes. Thanks a lot!

I think all others except Denso bootloader CAN modules use iso15765...

Sometimes it's at several places:

Well that's because it is loading Denso CAN kernel to CAN only ECU as you see from code, it first test if CAN kernel is uploaded, if not, switch to iso15765 and uploading CAN kernel and then switch back to CAN mode to continue data download

That is from the time when I couldn't get iso15765 kernel to work, and actually not sure if it works even yet in iso15765 mode as you can see, in diesel and 7058_can it is testing in CAN mode if kernel is running, and switching to iso15765 to upload CAN kernel, and then switch back to CAN mode

Yes, i can see it
I suppose that first 4 bytes must be with source/destination address. And all received data should include it. It's more easy to analyze log's and sniffed data for compare
If we use code like this:

It supposed that we don't use first 4 bytes of data. Not comfortable for me. It's only my opinion of course.

It looks like SH7058/59 only. I'll check twice.



Even worse, it could change in runtime several times

Yes, you are right. I think it should contain also src/dest addresses and should be modified. Don't remeber why it was in the first place done like that...

For Denso ECUs, SH7055 use Extended CAN mode with Denso CAN bootloader (default is K-Line), SH7058/9 default is iso15765 BUT it also has Denso CAN bootloader that uses Extended CAN. So when dealing with SH7058/9 ECUs, kernel is uploaded in iso15765 mode so not to mess say TCU when flashing (as they have Denso CAN bootloader also) but switched back to CAN as the kernel is CAN kernel. At the time when I was testing Diesel ECUs and EEPROM reads, I didn't have enough time to make kernel work as iso15765 mode so it left like that.

OK, I got one more question. In eeprom_ecu_subaru_denso_can.cpp file in function upload_kernel_subaru_denso_subarucan serial port is reopened at the end with is_iso15765_connection=false. Next function is read_mem_subaru_denso_subarucan. Should I treat connection as non iso15765?