FastECU development

MiikaS · **Joined:** Tue Jun 06, 2017 6:11 pm **Posts:** 215

Yes, because that's the next step after kernel upload.

alesv · **Joined:** Fri Aug 26, 2016 8:21 am **Posts:** 154

One more try. I reverted iso15765 patch. I could read SH7058 ECU without problems. SergArb, could you please check TCU modules one more? Thank you.

alesv · **Joined:** Fri Aug 26, 2016 8:21 am **Posts:** 154

I created pull request. If I remember right, it could be accessed as a branch. If not, it should be possible to merge to a branch locally without pushing it to remote. I'm sorry, I did not approved PRs for a long time and forgot a little bit some nuances. Rimwall (and the others who could help, of course), could you please check if syncing does not breake something? I could read SH7058 ROM with this patch. Please , check TCU modules. Thank you!

Rimwall, when we made all checks, please merge this PR to 'development-sync' branch.

Changes are also available in my fork in development branch.

Thank you!

SergArb · **Posted:** Thu Jul 04, 2024 7:33 am

alesv wrote:

One more try. I reverted iso15765 patch. I could read SH7058 ECU without problems. SergArb, could you please check TCU modules one more? Thank you.

No problem, will do it tonight.

SergArb · **Posted:** Thu Jul 04, 2024 2:28 pm

Tested, code is compatible now

alesv · **Joined:** Fri Aug 26, 2016 8:21 am **Posts:** 154

Quote:

Tested, code is compatible now

Excellent! P. 1 is done. P. 2 is almost done too. Waiting for rimwall to approve my pull request. I hope prior to this he and jimihimisimi would test some modules too. I could test more, but, as luck would have it, no Subarus in the yard

rimwall · **Joined:** Fri Aug 21, 2020 10:05 am **Posts:** 321

Thanks alesv! That is an amazing amount of progress in a very short time! Legendary!

I have merged my development-sync repo. I won't be able to test for a while (I'm not well setup for testing). Given it works for SergArb, I think we can keep moving forward.

What's the next step?

alesv · **Joined:** Fri Aug 26, 2016 8:21 am **Posts:** 154

I made PR to upstream, added some gitignore improvements and approved it. Now let's sync our forked repos. If you have any changes in 'development' branch, please save them temporary. They should not be deleted when fork will pull changes from upstream, but it's better to be safe. Then please fetch 'development' branch. It should add all changes that I've made to your 'development' branch.

If everything went well, I propose next.

Let 'development' branch become our main branch as there are several developers in our team.
Please do only small changes in 'development' branch that surely will fit one commit.
If you want to do significant changes (like adding new module), please create a new branch in your forked repo. It looks overkill for a single developer, but it helps to avoid merge conflicts and other mess when working in a team
When you're done, please make pull request to upstream. It will be approved to 'development' barnch (more likely). Then you could remove unneeded branch and get changes by fetching upstream.
If you meet a bug, please create issue on GitHub.

If you have any thoughts on this, please share them.

I'll start preparation to SerialProtActions refactoring next week.

PS I figured out that if you copied only 'main' branch from upstream you won't have access to others branches. To fix this you should run next command in repo dir

Code:

git branch -u upstream/development development

It will link your development branch to upstream's development branch.

jimihimisimi · **Joined:** Tue Apr 05, 2022 4:57 pm **Posts:** 60

alesv wrote:

Quote:

Tested, code is compatible now

Excellent! P. 1 is done. P. 2 is almost done too. Waiting for rimwall to approve my pull request. I hope prior to this he and jimihimisimi would test some modules too. I could test more, but, as luck would have it, no Subarus in the yard

Hmmm. What about setting up a couple bench ECU's and hanging them off a RasPi (or similar) to a VNC so we can share some modules among the whole team?

I've been working on a breakout board for a 1999 2.5RS ECU, we can start with that

alesv · **Joined:** Fri Aug 26, 2016 8:21 am **Posts:** 154

I added network code to FastECU, branch 'development-network'. It does not work yet because there's no thin client. FastECU now could work in two modes - direct (when it works with directly plugged equipment) and remote - over network (run .exe and set broker adderss like 'c:\>fastecu.exe 127.0.0.1:33314/password'). By default when no address specified it runs in direct mode.

I also refactored SerialPortActions class(es). API of SerialPortActions significantly changed. No class variables left, only getters/setters.

Old code

Code:

    serial->is_iso14230_connection = false;
    serial->is_can_connection = false;
    serial->is_iso15765_connection = true;
    serial->is_29_bit_id = false;
    serial->can_speed = "500000";
    serial->iso15765_source_address = 0x7E1;
    serial->iso15765_destination_address = 0x7E9;

 if (serial->is_can_connection || serial->is_iso15765_connection)

New code

Code:

    serial->set_is_iso14230_connection(false);
    serial->set_is_can_connection(false);
    serial->set_is_iso15765_connection(true);
    serial->set_is_29_bit_id(false);
    serial->set_can_speed("500000");
    serial->set_iso15765_source_address(0x7E1);
    serial->set_iso15765_destination_address(0x7E9);

 if (serial->get_is_can_connection() || serial->get_is_iso15765_connection())

I successfully read SH7058 ROM in direct mode.

Please test this branch.

Also if you have any wishes or suggestions, let's discuss them!

Oh, and you'll need OpenSSL x32 to connect to FastECU broker. Please install it and add to the path.

UPD Prevoiusly I wrote wrong number of OpenSSL I use. In fact I use Open SSL version 3.3.1 x32

Code:

"c:\Program Files (x86)\OpenSSL-Win32\bin\openssl.exe" -v
OpenSSL 3.3.1 4 Jun 2024 (Library: OpenSSL 3.3.1 4 Jun 2024)

rimwall · **Joined:** Fri Aug 21, 2020 10:05 am **Posts:** 321

Excellent progress alesv!

I still have on my 'todo' list to turn SergArb's code into proper modules, I need to find some time to get it done...

alesv · **Joined:** Fri Aug 26, 2016 8:21 am **Posts:** 154

rimwall wrote:

I still have on my 'todo' list to turn SergArb's code into proper modules, I need to find some time to get it done...

Please take your time! Next in line is FastECU client - it is much of code too. And I remind you just in case - please pull upstream's development branch to your repo (please make backup of your changes if they exist in that branch), or we could get out of sync again. Thank you!

SergArb · **Posted:** Sun Jul 14, 2024 12:41 pm

alesv, Great progress!

Compiled FastECU-Client and started FastECU with network support. Can't figure out, how to connect them?

Attachment:

noconnection.jpg

alesv · **Joined:** Fri Aug 26, 2016 8:21 am **Posts:** 154

Yeah, it lacks the docs...

It can't connect directly, so you need to run FastECU broker. The reason is to work from behind the NAT: FastECU->NAT->Broker<-NAT<-FastECU-client. Default client port is 33315, default server port is 33314.

Or you could run it locally over named pipes, then you won't need the broker. Just use 'local' instead of '127.0.0.1' in both client and server : 'fastecu.exe local:33315'.

SergArb · **Posted:** Sun Jul 14, 2024 2:39 pm

Oh, I will try, thank you!
FastECU broker compiles with Qt6 only?

RomRaider

FastECU development

Who is online