MS42 AD Logging - Knock Adaption Learned Values Table

323toslow · **Posted:** Wed Dec 27, 2017 8:15 pm

There has been a bit of conversation back and forth between myself, Pazi88, dschultz, and Husky99 in the stickied "DS2 - datalogging MS42 by serial protocol" thread in regards to not being able to use the RomRaider Logger LVT tab to view knock adaptions for the MS42 AD software DME's.

Thanks go to dschultz for the extensive time you have put into all things RR related and also giving a big kick in the correct direction for being able to use the LVT knock adaptions tables...as previously we AD software users weren't able to look at these tables.

Thank you Pazi88 for all of the time you have spent on the ECU definition files for AD software and others as well.

Thank you Husky99 for first catching the typo in the beta1 ECU definition file.

I have included a ZIP file that contains a corrected version of Pazi88's MS42 ECU Definitions, and updated versions of the official V326 logger definition files. There is also a text file in the ZIP which briefly explains what changes have been made to both the ECU and Logger definitions files to allow the knock tables to load. And so far from what I can tell on my end, the values that are populating the knock tables (1 through 6) are the correct learned ignition knock retard values.

I have made this thread to split off from the "DS2 - datalogging MS42 by serial protocol" thread, and focus it specifically on the learned values table aspect of the RR Logger for MS42 AD software DME's, to gauge whether or not it is now working properly and displaying the correct values.

I am asking that you guys/gals who have MS42 AD vehicles which are current on maintenance and run well, try these out and post screen shots of your knock tables. My ignition tables are stock EU, yet my knock tables look very nasty as can be seen in the screenshot, with all kinds of timing being pulled all over the place, even though my car seems pretty strong from off idle the whole way to 6,000rpm.

Attachment:

Scary.png

UPDATE : This updated set of logger definition files should now work on C6, CA, and AD s/w DMEs. Details of changes can be viewed within the text file contained in the ZIP.
viewtopic.php?f=59&t=12799

UPDATE : This updated MS42 ECU definition file contains additional definitions for AD and CA software versions. Details of the additions can be viewed within the text file contained in the ZIP.
http://www.romraider.com/forum/post66788.html

pazi88 · **Posted:** Thu Dec 28, 2017 8:31 am

Where do you live? Those adaptations seem reasonable if you live where the fuel isn't so great quality. At least ms41 cars from US I have seen same kind of adaptations. But ofcourse US is big place do there can also be all kinds of fuel qualities

barrymaxx · **Joined:** Sun Jan 22, 2017 3:43 am **Posts:** 44

Very nice work everyone.

I have a AD ecu I can test on. I run 87 octane only in this car :shock:

323toslow · **Posted:** Thu Dec 28, 2017 10:11 am

pazi88 wrote:

Where do you live? Those adaptations seem reasonable if you live where the fuel isn't so great quality. At least ms41 cars from US I have seen same kind of adaptations. But ofcourse US is big place do there can also be all kinds of fuel qualities

Im in Oregon, Pacific Northwest....I was really not expecting my knock tables to be full of pulled timing values hahaha. Although, my car is in need of some maintanance which I will be tending to in the next month or so and then i’ll hopefully see better looking tables. Another thing i’m going to do is try a different source of fuel, 93 octane next time I fill up.

barrymaxx wrote:

Very nice work everyone.

I have a AD ecu I can test on. I run 87 octane only in this car :shock:

I am looking forward to seeing screenshots of that.

Update : Check the original post for updates of the MS42 ECU & Logger Definitions ZIP file.

barrymaxx · **Joined:** Sun Jan 22, 2017 3:43 am **Posts:** 44

I am not having luck to get the learning tables to open. I thought they used to open for me but I cant remember. The error is the same with CA and AD, I tried both. Could be a computer or cable problem? I can datalog just fine and INPA works fine too...

16894 INFO [SwingWorker-pool-2-thread-2] - Connected to: COM1
16897 INFO [SwingWorker-pool-2-thread-2] - Serial connection initialised: SerialConnectionProperties[baudRate=9600, dataBits=8, stopBits=1, parity=2, connectTimeout=2000, sendTimeout=55]
16902 INFO [SwingWorker-pool-2-thread-2] - Retrieving vehicle info & A/F values...
16902 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Request ---> 12050B918D
16975 TRACE [SwingWorker-pool-2-thread-2] - ECU Read Raw Response <--- 12050B918D120EA07FFC83FE7FFB85D0000093
16975 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Response <--- 120EA07FFC83FE7FFB85D0000093
16978 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Request ---> 12050B938F
17039 TRACE [SwingWorker-pool-2-thread-2] - ECU Read Raw Response <--- 12050B938F1205A03384
17039 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Response <--- 1205A03384
17042 TRACE [SwingWorker-pool-2-thread-2] - addr:50291 size:1 lowest:50291 highest:50291
17042 TRACE [SwingWorker-pool-2-thread-2] - addr:64142 size:1 lowest:50291 highest:64142
17043 TRACE [SwingWorker-pool-2-thread-2] - EcuQueryRange length:0
17043 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Request ---> 1209060000C47301AB
17119 TRACE [SwingWorker-pool-2-thread-2] - ECU Read Raw Response <--- 1209060000C47301AB1205A06ED9
17119 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Response <--- 1205A06ED9
17120 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Request ---> 1209060000FA8E0168
17199 TRACE [SwingWorker-pool-2-thread-2] - ECU Read Raw Response <--- 1209060000FA8E01681205A0D265
17199 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Response <--- 1205A0D265
17199 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Request ---> 12050B031F
17279 TRACE [SwingWorker-pool-2-thread-2] - ECU Read Raw Response <--- 12050B031F1226A00000000000000000000000B000000000B4CBA078948000800000000000000007070017
17279 DEBUG [SwingWorker-pool-2-thread-2] - Mode:0 ECU Response <--- 1226A00000000000000000000000B000000000B4CBA078948000800000000000000007070017
17282 INFO [SwingWorker-pool-2-thread-2] - Current vehicle info & A/F values retrieved.
17539 INFO [SwingWorker-pool-2-thread-2] - Connection closed.
17540 DEBUG [Thread-499] - QueryManager started.
17541 ERROR [SwingWorker-pool-2-thread-2] - Retrieving Knock Load ranges... Error retrieving values
java.lang.NullPointerException
at com.romraider.logger.ecu.definition.xml.EcuDefinitionInheritanceList.getBaseRomIdNode(EcuDefinitionInheritanceList.java:112)
at com.romraider.logger.ecu.definition.xml.EcuDefinitionInheritanceList.getInheritanceList(EcuDefinitionInheritanceList.java:67)
at com.romraider.logger.ecu.comms.learning.DS2LearningTableValues.loadTable(DS2LearningTableValues.java:402)
at com.romraider.logger.ecu.comms.learning.DS2LearningTableValues.getTableAxisRanges(DS2LearningTableValues.java:343)
at com.romraider.logger.ecu.comms.learning.DS2LearningTableValues.doInBackground(DS2LearningTableValues.java:164)
at com.romraider.logger.ecu.comms.learning.DS2LearningTableValues.doInBackground(DS2LearningTableValues.java:70)
at javax.swing.SwingWorker$1.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at javax.swing.SwingWorker.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
17541 INFO [Thread-499] - RegOpenKeyEx error [2]
, trying serial connection...

Any ideas?

323toslow · **Posted:** Thu Jan 04, 2018 12:15 am

barrymaxx wrote:

I am not having luck to get the learning tables to open. I thought they used to open for me but I cant remember. The error is the same with CA and AD, I tried both. Could be a computer or cable problem? I can datalog just fine and INPA works fine too...

Any ideas?

I’m not even close to an expert in this stuff but I wouldn’t think it was your cable seeing as your pasted “log” shows you are connecting and were able to retrieve the A/F and Vehicle Info.

A few questions for you.

What ECU ID # does rrlogger show for both your AD and your CA dme?

Are you using the MS42 ECU & Logger Definitions v2.zip from 12-28-2017?

Did you make sure that the only MS42 ECU definition file showing in the main Rom Raider program, is the one from the MS42 ECU & Logger Definitions v2.zip file? It is named (Pazi's_MS42_ECU_Definitions_v0.35_beta1_FIX.xml)

barrymaxx · **Joined:** Sun Jan 22, 2017 3:43 am **Posts:** 44

323toslow thanks! I had multiple def files loaded into RR. I didnt know that could be a problem but that did the trick!

AD ecu ID 1430844 seems to work for me now. This is just a ecu on my bench. I have CA in a real car I will play with soon.

Normal finding

Attachment:

romraiderADPT_20180104-083037.png

After clearing adaptions via INPA

Attachment:

romraiderADPT_20180104-083757.png

Good stuff thanks guys. I will run with this for a while and post results of 87 octane vs 93 octane tables

323toslow · **Posted:** Thu Jan 04, 2018 10:42 am

barrymaxx wrote:

323toslow thanks! I had multiple def files loaded into RR. I didnt know that could be a problem but that did the trick!

Good stuff thanks guys. I will run with this for a while and post results of 87 octane vs 93 octane tables

Glad it works for you now and I am looking forward to some comparisons.

dschultz · **Posted:** Thu Jan 04, 2018 9:09 pm

barrymaxx wrote:

I am not having luck to get the learning tables to open.
17541 ERROR [SwingWorker-pool-2-thread-2] - Retrieving Knock Load ranges... Error retrieving values
java.lang.NullPointerException
at com.romraider.logger.ecu.definition.xml.EcuDefinitionInheritanceList.getBaseRomIdNode(EcuDefinitionInheritanceList.java:112)

This means you have a bad ECU definition file.

barrymaxx wrote:

After clearing adaptions via INPA

You can do this with RomRaider too.

323toslow · **Posted:** Thu Jan 04, 2018 10:41 pm

dschultz wrote:

You can do this with RomRaider too.

What he said.... RR Logger adaption clearing is way better than using INPA imo...you can select to clear either just knock adaptions, or lambda adaptions etc...instead of INPA clearing all adaptions.

Cloudforce · **Joined:** Wed Aug 27, 2014 7:57 am **Posts:** 259

323toslow wrote:

dschultz wrote:

You can do this with RomRaider too.

What he said.... RR Logger adaption clearing is way better than using INPA imo...you can select to clear either just knock adaptions, or lambda adaptions etc...instead of INPA clearing all adaptions.

Thats not correct! You can do the same with INPA!

323toslow · **Posted:** Fri Jan 05, 2018 2:16 am

Cloudforce wrote:

323toslow wrote:

dschultz wrote:

You can do this with RomRaider too.

What he said.... RR Logger adaption clearing is way better than using INPA imo...you can select to clear either just knock adaptions, or lambda adaptions etc...instead of INPA clearing all adaptions.

Thats not correct! You can do the same with INPA!

Wow, I never knew that, therefor I stand corrected. Please, fill me in.

n1kson · **Joined:** Mon Apr 03, 2017 12:26 pm **Posts:** 24

Can i make work with the same way "Knock retard current" on MS43?

n1kson · **Joined:** Mon Apr 03, 2017 12:26 pm **Posts:** 24

Hello, i can't make knock tables work on MS42 0110CA 7526753 ECU... Also when logging knock adaptation, retard, and global don't work.... All other stuff like engine speed, maf, load and etc works great... Please help

Quote:

, trying serial connection...
46100 INFO [SwingWorker-pool-2-thread-1] - Connected to: COM1
46104 INFO [SwingWorker-pool-2-thread-1] - Serial connection initialised: SerialConnectionProperties[baudRate=9600, dataBits=8, stopBits=1, parity=2, connectTimeout=2000, sendTimeout=55]
46115 INFO [SwingWorker-pool-2-thread-1] - Retrieving vehicle info & A/F values...
46493 INFO [SwingWorker-pool-2-thread-1] - Current vehicle info & A/F values retrieved.
46765 INFO [SwingWorker-pool-2-thread-1] - Retrieving Knock Load ranges...
48948 INFO [SwingWorker-pool-2-thread-1] - Connection closed.
48951 ERROR [SwingWorker-pool-2-thread-1] - Retrieving Knock Load ranges... Error retrieving values
com.romraider.logger.ecu.exception.InvalidResponseException: Invalid ecu id. Expected: 12. Actual: 00.
at com.romraider.io.protocol.ds2.iso9141.DS2ResponseProcessor.assertEquals(DS2ResponseProcessor.java:84)
at com.romraider.io.protocol.ds2.iso9141.DS2ResponseProcessor.validateResponse(DS2ResponseProcessor.java:59)
at com.romraider.io.protocol.ds2.iso9141.DS2ResponseProcessor.extractResponseData(DS2ResponseProcessor.java:68)
at com.romraider.io.protocol.ds2.iso9141.DS2LoggerProtocol.processReadMemoryRangeResponse(DS2LoggerProtocol.java:193)
at com.romraider.logger.ecu.comms.io.connection.DS2LoggerConnection.sendAddressReads(DS2LoggerConnection.java:120)
at com.romraider.logger.ecu.comms.learning.DS2LearningTableValues.doInBackground(DS2LearningTableValues.java:167)
at com.romraider.logger.ecu.comms.learning.DS2LearningTableValues.doInBackground(DS2LearningTableValues.java:70)
at javax.swing.SwingWorker$1.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at javax.swing.SwingWorker.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
48956 INFO [Thread-1067] - RegOpenKeyEx error [2]
, trying serial connection...
49033 INFO [Thread-1067] - Connected to: COM1
49034 INFO [Thread-1067] - Serial connection initialised: SerialConnectionProperties[baudRate=9600, dataBits=8, stopBits=1, parity=2, connectTimeout=2000, sendTimeout=55]
51142 INFO [Thread-1067] - ECU ID = 7526753
51268 INFO [Thread-1067] - Connection closed.
51270 INFO [Thread-1067] - RegOpenKeyEx error [2]
, trying serial connection...
51334 INFO [Thread-1067] - Connected to: COM1
51335 INFO [Thread-1067] - Serial connection initialised: SerialConnectionProperties[baudRate=9600, dataBits=8, stopBits=1, parity=2, connectTimeout=2000, sendTimeout=55]
51336 INFO [Thread-1067] - TX Manager Started.
102198 INFO [AWT-EventQueue-0] - Loading logger config for new ECU ID: 7526753, loaded protocol DS2: 119 parameters, 0 switches from def version 326.loaded protocol DS2: 119 parameters, 0 switches from def version 326.
677736 INFO [Thread-1067] - Connection closed.
677737 INFO [Thread-1067] - TX Manager Stopped.
680054 INFO [SwingWorker-pool-2-thread-2] - RegOpenKeyEx error [2]
, trying serial connection...
680115 INFO [SwingWorker-pool-2-thread-2] - Connected to: COM1
680116 INFO [SwingWorker-pool-2-thread-2] - Serial connection initialised: SerialConnectionProperties[baudRate=9600, dataBits=8, stopBits=1, parity=2, connectTimeout=2000, sendTimeout=55]
680117 INFO [SwingWorker-pool-2-thread-2] - Retrieving vehicle info & A/F values...
680482 INFO [SwingWorker-pool-2-thread-2] - Current vehicle info & A/F values retrieved.
680577 INFO [SwingWorker-pool-2-thread-2] - Retrieving Knock Load ranges...
682710 INFO [SwingWorker-pool-2-thread-2] - Connection closed.
682710 ERROR [SwingWorker-pool-2-thread-2] - Retrieving Knock Load ranges... Error retrieving values
com.romraider.logger.ecu.exception.InvalidResponseException: Invalid ecu id. Expected: 12. Actual: 00.

pazi88 · **Posted:** Wed May 16, 2018 3:54 am

Do you have ms42 ecu definitions also selected in editor?

RomRaider

Forum rules

MS42 AD Logging - Knock Adaption Learned Values Table

Who is online