RomRaider

RomRaider does not support A2L, so you won't be able to load it in the Editor.
The Editor only supports XML formatted RomRaider definitions.

The repo is xml. He's gone to the max converting all the A2L defs into RR xml format!

I'm confused by the files here. combine_all.bat does not reference the A2L.xml file in the folder and table_templates is missing from the folder. Am I supposed to rename A2L.xml to table_templates?

Why is there already a nissandefs.xml in the folder when it gets deleted in the combine_all.bat?

Combine all works identically to how it does in A33B's repository. The only difference is that my definition base is already setup as an xml file. But there aren't any differences in our methods except for not having to convert it to an xml file if you want Notepad++ to look pretty Just in case someone wanted to add a non-relabeled definition file to their folder, I left the majority of the old labeling at the end of the template so that it should be fully compatible with any definition base. As for why there's already a nissandefs.xml, so that you don't have to manually click combine all whenever there's an update to the repo. It's how my personal repo is designed so it's just how I have the public one setup.

Great thanks. You should prob add to the readme that the nissandefs.xml is already good to go.

So what is A2L.xml used for if combine_all.bat doesn't use it?

Combine all will merge all .xml files and the table_templates file into one. So removing table_templates from the folder still merges all .xml files. All RomRaider cares about is having the template and the definition file in the same file, how it gets there is irrelevant. However, there might be a reason A33B didn't just label the table template file as a .xml? But everything has worked as intended by just labeling it as a .xml Technically you could rename A2L.xml as table_templates and it would still work just fine, but I see no reason to do so when the .xml tag already works.

Ah yep. Makes sense. Thanks.

because I need to insert the contents of table_template before all the defs in the final xml; and combine_all does



to insert all the ECU defs, which doesn't control the order of concatenation. So renaming to table_template.xml would usually not work as intended.

Any particular reasoning for this? Opening ROMs that were placed above the A2L.xml template inside of nissandefs still open up as intended. But that makes sense why it's not a .xml file type then. Since if it were, it wouldn't be distinguishable from the other files.

I haven't touched that .bat since 2017, but I vaguely recall RR wasn't happy when the NISSAN_BASE block wasn't placed before each ECU def. If that's no longer the case, then the combine_all script could definitely be simplified and table_templates renamed to .xml

Dschultz must've touched up RR's code since then haha Speaking of which, I still have to remove the "file not found" error when you run combine all.

I think I might start working on adding some maps to G35 and 350z ROM's exclusively. All G35 and 350z ROM's cross reference incredibly well with CF48D. To the point that the values are practically 1:1. So I think 350z and G35 ROMs will get some love. For other vehicles, I don't have much interest in pursuing. I might make my repo G35 and 350z exclusive, and have A33B's repo be for everything else. But (at least for now) I'll continue to allow my template to support all vehicles, but I just won't be actively focusing on non-G/Z vehicles.

However, this doesn't mean that I won't work on non-G/Z ROM's. Some non-G/Z SH7058 ROMs have actually shown to be quite easy to cross reference with CF48D. But it would probably be a case-by-case basis rather than actively pursuing them.

That's a great idea. Doubling up definition repositories is messy. Just keep the ones in there that have the extra stuff in them and we can always use the template for our own ROMS if we define some extra stuff.

Great work.

Agreed. Given how I don't see myself being interested in non-Z/G ROMs in the near future, I don't see why I should keep them here. Especially because it literally wouldn't add anything for them haha Just some relabeling and that's about it. We'll see if A33B wants to pick up the non-Z/G defs for his repo so then he can continue maintaining them. He's quite a bit more experienced than I am with non-Z/G ROMs, so there isn't anyone better for it than him

Edit;

Thanks to switching to Focusing on Z/G exclusive, I’ve now written a basic software that potentially can auto define the DTCs based on offset. So you enter in the first DTC address and it can automatically fill in the rest and write out the definition for you.

Based off the auto-defined results, it seems to be 100% accurate for any USDM Z/G ROM, with G ROMs being a tad bit different due to different sensors, AWD, etc. But it seems that the only adjustment needed is bit extending some of the DTC templates to support them. Just checked a JDM 03 Z ROM, it actually seems that the offsets work for all market Z/G's The only issue is that they use some different bits, so bit extension is required of course.