RomRaider Logo

RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Sat Feb 21, 2026 2:43 pm

All times are UTC




Post new topic Reply to topic  [ 106 posts ]  Go to page Previous  1 ... 3, 4, 5, 6, 7, 8  Next
Author Message
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Sun Nov 04, 2012 9:12 pm 
Offline
Experienced
User avatar

Joined: Fri Mar 02, 2012 6:09 pm
Posts: 183
Location: DSM, IA :: 2011 STi - Dom3.5XTR - E85
The owner of the 2012 STi put his stock airbox back on and with only making tuning changes for the different intake, his FBKC that was showing up is gone. His IATs no longer rise over the pull like they did with the Cobb SRI. The weather conditions here today are the same as yesterday.

It sounds like there is a link to IAT which makes sense from what I'm seeing. It seems like a rapid increase in IAT is definitely a trigger for this preemptive knock correction.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Mon Nov 05, 2012 12:14 am 
Offline
Senior Member

Joined: Sat Feb 12, 2011 11:27 pm
Posts: 2032
Location: Northern NSW
td-d wrote:
Interestingly, there's also a switch pretty close to the beginning of the routine, that if not equal to 1 (i.e. condition false), fast tracks the routine right the way down to put -5 straight into FBKC.


Patrick has this -5 condition!


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Mon Nov 05, 2012 12:48 am 
Offline
RomRaider Donator
User avatar

Joined: Mon Dec 15, 2008 7:12 am
Posts: 672
Location: The Philippines
For AZ1G101N (Thanks Td-d)

Min rpm activation is 1700 rpm, max rpm 3800
Min load at 1,2, max 2.8
Primary open loop activation at 1 lambda, min coolant threshold at 78 celsius.

For those with bigger turbos or just stage 1 and 2, tuner can increase range for rpm and el so preemptive fbkc can cover what tuned map reaches. Similar to what we do for flkc and Iam range.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Nov 06, 2012 8:26 am 
Offline
Experienced
User avatar

Joined: Thu Jul 22, 2010 10:22 am
Posts: 148
Location: Australia
td-d wrote:
I believe there's a throttle plate opening % delta threshold in there - would be interesting to log to note (it's checked against a 2d table)

0xFFFF6524

This is the 2D table - IAT is the x-axis:

Code:
ROM:00086CD8 word_86CD8:     .data.w h'10            ; DATA XREF: sub_33972:loc_339DEo
ROM:00086CD8                                         ; sub_33A92:off_33B94o
ROM:00086CDA                 .data.w h'800
ROM:00086CDC                 .data.l flt_C7EF4
ROM:00086CE0                 .data.l word_CA14A      ; = 1.0e1
ROM:00086CE4                 .float 0.0019073777
ROM:00086CE8                 .float 0.0

I did some logging today and 0xFFFF6524 is throttle plate opening and 0xFFFF66E8 is the throttle plate opening delta. So the table result is the PEKC min throttle opening threshold.

There's some per gear logic/tables in sub_33A92 that also effect PEKC
Attachment:
Untitled11.png

There are two sets of per gear tables, in the green ellipse all tables gear 1 to 5 all values are set to 19.922 and in the red ellipse all tables gear 1 to 5 are set to 26.953.
Attachment:
Untitled11.png

I'm unsure what dictates the switch between the tables in the green ellipse to the ones in the red but my car seems to only use the red ones. The result from these tables is compared to 3 param's even after logging these i'm still unsure what they are. The result off the comparison between these param's and the per gear table results determins if switch value at 0xFF76CD is set or cleared. For PEKC to be active 0xFF76CD needs to be zero.
Attachment:
Untitled11.png


You do not have the required permissions to view the files attached to this post.

_________________
09 ADM WRX/ 3" Exforce Turbo Back, Hyperflow TMIC, AEM CAI, Perrin Turbo Inlet, TGV Delete, Ported VF-52, Walbro Pump, Hybrid boost control (Grimmspeed EBCS/MBC), SI-Drive Mode Selector (3 pos Rocker Sw)/ Self tuned @ 17 Psi, Last dyno run 206Kw.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Nov 06, 2012 8:51 am 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
Easty wrote:
I'm unsure what dictates the switch between the tables in the green ellipse to the ones in the red but my car seems to only use the red ones.


It's based off whether FFFF67D0 is set to 1 or 0 - trying to track down what sets that.

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Nov 06, 2012 8:59 am 
Offline
Experienced
User avatar

Joined: Thu Jul 22, 2010 10:22 am
Posts: 148
Location: Australia
td-d wrote:
Easty wrote:
I'm unsure what dictates the switch between the tables in the green ellipse to the ones in the red but my car seems to only use the red ones.


It's based off whether FFFF67D0 is set to 1 or 0 - trying to track down what sets that.

how did you get FFFF67D0? All i get is this

Attachment:
Untitled11.png


You do not have the required permissions to view the files attached to this post.

_________________
09 ADM WRX/ 3" Exforce Turbo Back, Hyperflow TMIC, AEM CAI, Perrin Turbo Inlet, TGV Delete, Ported VF-52, Walbro Pump, Hybrid boost control (Grimmspeed EBCS/MBC), SI-Drive Mode Selector (3 pos Rocker Sw)/ Self tuned @ 17 Psi, Last dyno run 206Kw.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Nov 06, 2012 9:09 am 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
Easty wrote:
how did you get FFFF67D0?


Further up the routine:

Code:
ROM:00033AA0                 add     #unk_FFFFFFF8, r15
ROM:00033AA2                 mov.l   #unk_FFFF6854, r2
ROM:00033AA4                 fmov.s  @r2, fr15
ROM:00033AA6                 mov.l   #Ram_IAT, r2
ROM:00033AA8                 fmov.s  @r2, fr14
ROM:00033AAA                 mov.l   #Ram_Gear, r6
ROM:00033AAC                 mov.l   #sub_22BAE, r2
ROM:00033AAE                 jsr     @r2 ; sub_22BAE
ROM:00033AB0      mov.b   @r6, r14


If you explore sub_22BAE
Code:
ROM:00022BAE
ROM:00022BAE sub_22BAE:                              ; CODE XREF: sub_12440+2Ap
ROM:00022BAE                                         ; sub_139DA+5Cp ...
ROM:00022BAE                 mov.l   #h'FFFF67D0, r6
ROM:00022BB0                 mov.b   @r6, r0
ROM:00022BB2                 cmp/eq  #1, r0
ROM:00022BB4                 rts
ROM:00022BB6


true / false bit is then passed on to r0, which is pass on to the stack:

Code:
mov.b   r0, @(4,r15)


this value is passed back from the stack to r0 later on:

Code:
ROM:00033AD4                 mov.b   @(4,r15), r0
ROM:00033AD6                 cmp/eq  #1, r0


and on the basis of this, either the 'red' branch is followed (false) or the green branch is followed (true).

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Nov 06, 2012 9:16 am 
Offline
Experienced
User avatar

Joined: Thu Jul 22, 2010 10:22 am
Posts: 148
Location: Australia
Oh yeah i see it now!

any theories on what param's dword_FFFF6854, dword_FFFF9084 and dword_FFFF9088 are?

_________________
09 ADM WRX/ 3" Exforce Turbo Back, Hyperflow TMIC, AEM CAI, Perrin Turbo Inlet, TGV Delete, Ported VF-52, Walbro Pump, Hybrid boost control (Grimmspeed EBCS/MBC), SI-Drive Mode Selector (3 pos Rocker Sw)/ Self tuned @ 17 Psi, Last dyno run 206Kw.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Wed Mar 20, 2013 4:13 pm 
Offline
RomRaider Developer
User avatar

Joined: Tue Jan 23, 2007 9:11 pm
Posts: 966
Location: Hillsboro, Oregon
td-d wrote:
Interestingly, there's also a switch pretty close to the beginning of the routine, that if not equal to 1 (i.e. condition false), fast tracks the routine right the way down to put -5 straight into FBKC.


Have you linked this into the IAM re-evaluation or the evaluation for multiplier value of high det / low det fueling tables? The 32 bit ECUs do this at random for no reason at all sometimes (no knock sum logged) which on the 07 STI will cause an IAM re-evaluation and a fast learn. My hypothesis is if you can trigger the Vishnu reset (fast LTFT learn) it also includes a fast IAM re-evaluation where FBKC (and not FLKC) can show up and every once in awhile you may catch part of the IAM flopping, but I have only caught this logging at a very high sample rate. Of course if your initial IAM is 1, it is very hard to catch. Set initial IAM to 0.5 and you could catch your switching logic. It looks like the IAM re-evaluation if, then code.

I performed about 6K miles of logging on the stock 07 STI tune. I would see the still to be fully explained logic such as this often when filling up with gas on a long trip and letting cruise control do my driving on a hilly highway.

In my 06 WRX, I always had timing pulled (this was way before knock sum was available) where FBKC on a powershift down the 1/4 mile would pull up to 5* but then rapidly (faster than defined) jump to base+KC between shifts. The rapidness was rpm dependent and not time dependent as each gear would hold the pulled timing longer down a logged 1/4 mile run.

All of these situations are similar and if I were developing (thinking as an engineer and tuner) a pre knock condition function, I would have one function with different behavior control variables input into one "fast_learn" function.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Sun Apr 27, 2014 7:43 pm 
Offline
RomRaider Donator

Joined: Fri Feb 25, 2011 9:27 pm
Posts: 494
Location: Romania
Anybody here has some feedback about disabling this preemptive knock correction ? Any negative effects ?

I just did that today on my car - I put 0 instead of the -1.4 value found at 0x00010 past the normal FBKC.
The main reason for me was that my CEL was flashing (merpmod cel flash on knock) on FBKC but more than 90% of it was preemptive knock and the whole CEL flash thing was not very helpful until I did that.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Mon Nov 17, 2014 3:19 am 
Offline
RomRaider Donator

Joined: Thu Dec 29, 2011 2:04 am
Posts: 181
Hey guys,

I am a couple miles behind you on reverse engineering the logic but I am trying to catch up. I have a question which hopefully can be answered relatively easily :

Is there more than 1 function that increment or decrement feedback correction value (I have found one separate function that sets it to zero but nothing else) ? Reason I ask is that the function I have been looking at seem to decrement it only based on a ram variable documented as E_knock_on_cyl4 which I can't seem to see triggering in my logs when I get FBCK. (it does from time to time go to 1 and I see the knock sum increasing but not when I get FBCK)

I too am getting -1.4 degree of timing correction while I modified the main retard value to -1.52. I'd like to understand what is driving the ECU to do this. Slight edit : I realized last night that I am logging the 8 bit FBKC value which doesn't have enough resolution to display the extra -0.12. I'll have to log the float or increase my retard value. Regardless though, my question on E_knock_on_cyl4 still stand

Thanks !


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Fri Nov 28, 2014 2:57 am 
Offline
Experienced

Joined: Sun Oct 16, 2011 7:57 am
Posts: 150
Hi guys,

Wondering if anybody has the ECUFlash defs for AZ1G202G available ?

Cheers,

Adrian


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Fri Nov 28, 2014 3:01 pm 
Offline
RomRaider Donator

Joined: Fri Feb 25, 2011 9:27 pm
Posts: 494
Location: Romania
I'm using this

<table name="Feedback Correction Retard Value ALTERNATE" address="ce0f0">
</table>

for AZ1G202G ....


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Sat Nov 29, 2014 9:11 am 
Offline
Experienced

Joined: Sun Oct 16, 2011 7:57 am
Posts: 150
Thanks Andea! :)


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Mon Feb 09, 2015 3:35 am 
Offline
Newbie

Joined: Wed Mar 21, 2012 10:45 pm
Posts: 69
anyone have the tables for A8DH202X?


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 106 posts ]  Go to page Previous  1 ... 3, 4, 5, 6, 7, 8  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 7 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl