RomRaider

Hello all!

In the process of trying to add TCM CID support to RR logger (RE5R05A for the 350z's) and I can't seem to get RR logger to understand the CIDs properly. I'm presuming a user error on my end, as these ecubyteindex stuff aren't the nicest form of addressing haha However, I'm using the convertor used for the ECU definitions and it still doesn't like it.

CID's grabbed via 0x21 and 0x22;



Definitions for three CID's;


Just for clarification, ALL CID's appear in RR logger. The issue is the ones that SHOULD be there are disappearing once you connect to the TCM, as a result of RR not thinking the CIDs are active. So based off byte 40, it should be 0xFF. So I have no clue how bit 5 is reading 1, but bit 4 is somehow reading 0. I transferred the TCM defs over to a new logger def, to prevent the ECU from interfering, but it didn't seem to change anything.

Using Nisprog, "0x22 0x11 0x09 0x04 0x01" (Accelerator Pedal Position) does give accurate results. Yet, this isn't showing up as supported within RR logger. What else is strange is that P4361 - Ignition Timing in the RR logger defs shows an address of 0x221109 and byte 0x41 bit 7, just like my own 0x221109.

Edit; the ECU ID translates to “Z CF40A”, while NDS2 shows CF40A. So the ECUID is being properly transmitted, but RR logger is somehow showing “CF48D” (ECU ID) as the TCM ID. I believe this happened even when using a purely TCM logger definition.

I have a spreadsheet that defines the ECU/TCU responses and how they map to the Logger definition ecubyteindex and ecubit. I'll have to dig it up for you.

Sounds good! Is there anyway to do this manually via CID responses? Because I want to add ABS module logging as well

Probably answered elsewhere, but might as well ask here. Is it normal for RR logger to show all module's RAM parameters? So even if you select the ECU box, it will still let you datalog the TCM parameters and vice versa. Is this intended? Reason I ask is because NDS2 which datalogs via CID's exclusively states that you can't datalog multiple ECU's at one time.

If you always see the RAM parameters then they are not being filtered to match the ECU ID being logged.

I started a definition reference document here.

But that's the thing, it's making me think that RR Logger isn't switching between modules and is just staying connected to the ECU. This would explain why the TCM SID's aren't being registered properly, as the ECU and TCM have different supported CID's. 221101 is supported by both the TCM and ECU, and so the TCM's 221101 appears as supported in RR Logger. But 221109 is ONLY supported by the TCM and doesn't appear as supported in RR Logger. So I think the issue isn't the ecubyteindex stuff, but rather, RR Logger not switching the destination address when you switch modules. Also, all the TCM CID's that appear as supported in RR Logger appear to also be supported by the ECU, while any TCM CID that appears as unsupported does not have a matching supported ECU SID.

Post your logger def and your rr_system.log for a TCM logging session.

For sure! Just gotta wait till my new laptop comes in today or tomorrow haha

Here are the files. Definitely seems odd how it doesn't filter the parameters.

The unit command has the ECU address in it:
8690 DEBUG [Thread-6] - J2534/ISO14230 Fast Init: deviceId:1, channelId:3, timing:83FC10C15D8F3C
So you are querying the ECU not the TCU, assuming this is the ECU ID CF48D.
I'm not sure why the address is not changing, must be a "feature".

Yup! ECUID CF48D and TCMID CF40A But I'm glad I was right about it just keeping the ECU's address haha I can't even tell you how many times I checked the definition file for errors in the ecubyteindex stuff

One good thing to note is that the logger is at least showing all the modules' checkboxes. It would just be nice if it would change it's destaddr when you changed the module lol For when the bug is fixed, will each module just be in numerical order? So if it goes ECU, TCM, ABS, then 1 = ECU, 2 = TCM, and 3 = ABS?

Edit;
If it helps, IIRC, even when ONLY the TCM module was listed, it still wasn't reading right. So I wonder if RR logger for NCS protocol is just defaulting the the destination address of 0x10 (ECU) rather than checking the definition file for the modules' addresses.

Target 3 = Both ECU and TCU right now.

The code takes the address from the Module. The Module gets the address from the definition. At the moment I'm not sure why it is not replaced correctly.

Ah, alright. So there isn't currently any target setup for non-ECU/TCM modules then? The only other CID-based modules would be the BCM and ABS module.



Maybeeee here? I'm not well versed in java at all, but maybe it just keeps the address from the startreq command since you would need to stopreq to the ECU, then startreq to the TCM if you wanted to switch between modules.

From src/main/java/com/romraider/io/j2534/api/J2534ConnectionISO14230.java;