Random Stuff To Fix

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

This thread is a notepad for stuff that I find as I start digging! Don't take anything personally :-)

1) Build.xml expects svn to be present. I've hacked it to run git instead, however it might be better to just cut that bit out in the mean time otherwise it will mandate building in a terminal/environment in which git is available. That's likely a good idea anyway, but may not be the case initially. Don't wanna piss off Dale more than I need to just yet :-)

2) Importing from com.sun is bad bad form and == non-cross platform apps and deps on specific J versions:

Code:

build:
    [mkdir] Created dir: /home/fred/RomRaider/build/classes
    [javac] /home/fred/RomRaider/build.xml:330: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 362 source files to /home/fred/RomRaider/build/classes
    [javac] /home/fred/RomRaider/src/com/romraider/editor/ecu/ECUEditor.java:44: warning: com.sun.org.apache.xerces.internal.parsers.DOMParser is Sun proprietary API and may be removed in a future release
    [javac] import com.sun.org.apache.xerces.internal.parsers.DOMParser;
    [javac]                                                  ^
    [javac] /home/fred/RomRaider/src/com/romraider/util/SettingsManagerImpl.java:27: warning: com.sun.org.apache.xerces.internal.parsers.DOMParser is Sun proprietary API and may be removed in a future release
    [javac] import com.sun.org.apache.xerces.internal.parsers.DOMParser;
    [javac]                                                  ^
    [javac] /home/fred/RomRaider/src/com/romraider/xml/DOMSettingsBuilder.java:24: warning: com.sun.org.apache.xml.internal.serialize.OutputFormat is Sun proprietary API and may be removed in a future release
    [javac] import com.sun.org.apache.xml.internal.serialize.OutputFormat;
    [javac]                                                 ^
    [javac] /home/fred/RomRaider/src/com/romraider/xml/DOMSettingsBuilder.java:25: warning: com.sun.org.apache.xml.internal.serialize.XMLSerializer is Sun proprietary API and may be removed in a future release
    [javac] import com.sun.org.apache.xml.internal.serialize.XMLSerializer;
    [javac]                                                 ^
    [javac] /home/fred/RomRaider/src/com/romraider/editor/ecu/ECUEditor.java:397: warning: com.sun.org.apache.xerces.internal.parsers.DOMParser is Sun proprietary API and may be removed in a future release
    [javac]             DOMParser parser = new DOMParser();
    [javac]             ^
    [javac] /home/fred/RomRaider/src/com/romraider/editor/ecu/ECUEditor.java:397: warning: com.sun.org.apache.xerces.internal.parsers.DOMParser is Sun proprietary API and may be removed in a future release
    [javac]             DOMParser parser = new DOMParser();
    [javac]                                    ^
    [javac] /home/fred/RomRaider/src/com/romraider/util/SettingsManagerImpl.java:44: warning: com.sun.org.apache.xerces.internal.parsers.DOMParser is Sun proprietary API and may be removed in a future release
    [javac]             DOMParser parser = new DOMParser();
    [javac]             ^
    [javac] /home/fred/RomRaider/src/com/romraider/util/SettingsManagerImpl.java:44: warning: com.sun.org.apache.xerces.internal.parsers.DOMParser is Sun proprietary API and may be removed in a future release
    [javac]             DOMParser parser = new DOMParser();
    [javac]                                    ^
    [javac] /home/fred/RomRaider/src/com/romraider/xml/DOMSettingsBuilder.java:51: warning: com.sun.org.apache.xml.internal.serialize.OutputFormat is Sun proprietary API and may be removed in a future release
    [javac]         OutputFormat of = new OutputFormat("XML", "ISO-8859-1", true);
    [javac]         ^
    [javac] /home/fred/RomRaider/src/com/romraider/xml/DOMSettingsBuilder.java:51: warning: com.sun.org.apache.xml.internal.serialize.OutputFormat is Sun proprietary API and may be removed in a future release
    [javac]         OutputFormat of = new OutputFormat("XML", "ISO-8859-1", true);
    [javac]                               ^
    [javac] /home/fred/RomRaider/src/com/romraider/xml/DOMSettingsBuilder.java:59: warning: com.sun.org.apache.xml.internal.serialize.XMLSerializer is Sun proprietary API and may be removed in a future release
    [javac]             XMLSerializer serializer = new XMLSerializer(fos, of);
    [javac]             ^
    [javac] /home/fred/RomRaider/src/com/romraider/xml/DOMSettingsBuilder.java:59: warning: com.sun.org.apache.xml.internal.serialize.XMLSerializer is Sun proprietary API and may be removed in a future release
    [javac]             XMLSerializer serializer = new XMLSerializer(fos, of);
    [javac]                                            ^
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 12 warnings
    [mkdir] Created dir: /home/fred/RomRaider/build/windows/lib
      [jar] Building jar: /home/fred/RomRaider/build/windows/lib/RomRaider.jar
    [mkdir] Created dir: /home/fred/RomRaider/build/linux/lib
      [jar] Building jar: /home/fred/RomRaider/build/linux/lib/RomRaider.jar

Built, though! Now let's try to run it :-)

Fred.

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

After taking a shot of gin to sooth my nerves after executing ant for the first time in 7 years or so, I found the following, likely known, things:

run.sh expects ~/.RomRaider to exist and thus fails when it's not (new user will go WTF) - added a mkdir -p before the run line which solves it.

The command inside dumps the output to that log file which means you get zero feedback when it doesn't work. Confusing behaviour. Even if we obscure the real messages, we should likely dump a "sorry, failed"

run.sh expects RomRaider.jar to be in the root of the project, not the build/linux/lib/RomRaider.jar location. I just copied it out. I might change the script to expect it there instead.

No, that doesn't work, and yields the same result as cd build/linux/lib;java -jar RomRaider.jar :

Code:

Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/log4j/Logger
   at com.romraider.ECUExec.<clinit>(Unknown Source)
Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Logger
   at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
   at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
   ... 1 more
Could not find the main class: com.romraider.ECUExec. Program will exit.

Ahh, I see why, the script feeds Java a lib path that is relative to the project root, but expects the jar to be in project root, which it's not. I'll add a cp line instead for now.

Fred.

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

Funky stuff with windowing:

The cursor is always a window edge resizing cursor.
When you try to resize the bottom right, the top left drifts downward and to the right.
When you unmaximise it doesn't remember the previous size.
It doesn't seem to have native look and feel by default, though this has to be on purpose, and I probably prefer it anyway.

Expected behaviour stuff:

When you hold down the inc/dec buttons in a table, you don't get a repeat effect.
You can't see the colours in a table while you're changing values, highlighting the borders of the cells only seems better?
Opaque resize of tables would be nice.
Smaller icons for the controls such as inc/dec, save/load etc would look a lot cleaner and free up screen real estate.
Something to indicate exactly what has/has not been changed when windows are closed (ie, in the list on the left)

I'm going to play with the build stuff more and figure out what my changes have done and maybe just leave it at that for now.

Fred.

dschultz · **Posted:** Tue May 01, 2012 5:11 pm

You're running a Mac right!? Not much testing in that environment, only Linux and Windows.

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

I've got mac and Linux and had the same result on both re run.sh, as did another guy I had playing with it.

No drama, just wanted to note down everything as I'll soon forget it once it becomes second nature.

Fred.

dschultz · **Posted:** Tue May 01, 2012 5:39 pm

The run.sh is basically for command line starting after you have unzipped the built project which is in romraider/build/dist/<insert-your-OS-name-here>

I would expect most Win/Linux users to be running the "installed" version of RomRaider rather than the unzipped version, to each his own.

I guess I forgot to fix run.sh when I moved the settings etc. to the .RomRadier/ dir, sorry.

I was looking at replacing the DOMParser references, just haven't got to it yet.

BTW: if you're looking for the list of wishes, what needs fixing, etc... look here:
http://trac.assembla.com/romraider/report/3

What are we gonna do with this?

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

dschultz wrote:

The run.sh is basically for command line starting after you have unzipped the built project which is in romraider/build/dist/<insert-your-OS-name-here>

OK, make's sense. I'm thinking from a svn co/git clone point of view. Perhaps it would make sense to clean up some (or all) of those things laying around into a resource dir and include them with that. Such things can be part of the maven migration, though, so don't worry about it. There will be a lot of shuffling going on in a branch on my account soon. Don't worry about making changes, just keep moving forward, I'll git rebase my work onto whatever you have in yours/official when the time is right.

Quote:

I would expect most Win/Linux users to be running the "installed" version of RomRaider rather than the unzipped version, to each his own.

What is an "installed" version on Debian? Arch? Fedora? Gentoo? Slackware? That's a hard thing to define. If I didn't run "apt-get install X" on X, then I don't consider X to be "installed". I typically never allow scripts to have a free reign while "installing" either. Sometimes I even create a VM and transfer the output afterward.

Quote:

I guess I forgot to fix run.sh when I moved the settings etc. to the .RomRadier/ dir, sorry.

No need to be sorry! :-p Fixed now, or at least "works for me" pull/fetch at your leisure.

Quote:

I was looking at replacing the DOMParser references, just haven't got to it yet.

Don't. I'll do it as part of the maven upgrade too.

Quote:

BTW: if you're looking for the list of wishes, what needs fixing, etc... look here:
http://trac.assembla.com/romraider/report/3

What are we gonna do with this?

That's a question that I've also been pondering. I have a mantisBT tracker setup that you could use if you prefer it. Or we could keep using that. I'm not too familiar with trac, but it's fairly big, so I guess it can't be too bad?

Fred.

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

Copyright stuff:

Some places say copyright RomRaider - unless RR is a legal entity, AND, only Jared committed to it, OR, others who did also assigned copyright to Jared, then this is both technically and legally wrong and should be fixed.

Some files don't have headers at all. All source files should have a GPL header in them at the top if you want to do the 100% right thing by the GPL guide.

Any file worked on by N people over M years should read something like this:

Copyright 2006-2012 Jared Gould, Bob Clown, Steve Jobs, Alexander Snottlepot, Prince Harry

With the year range accurate for the file contents, not the project, and the list of names using first and surname complete and accurate.

Fred.

dschultz · **Posted:** Tue May 01, 2012 7:59 pm

You'll have to ask Jared. I remember him mentioning RomRaider LLC a while back.

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

Even if it does, the people all have to assign, or it should be done as above. For example, have you signed a copyright assignment contract with Jared? If not, your name should be on the source as it is copyright by you AND whoever else.

dschultz · **Posted:** Tue May 01, 2012 8:04 pm

Fearless wrote:

Quote:

I would expect most Win/Linux users to be running the "installed" version of RomRaider rather than the unzipped version, to each his own.

What is an "installed" version on Debian? Arch? Fedora? Gentoo? Slackware? That's a hard thing to define. If I didn't run "apt-get install X" on X, then I don't consider X to be "installed". I typically never allow scripts to have a free reign while "installing" either. Sometimes I even create a VM and transfer the output afterward.

No fancy package manager stuff...
Installing on Linux is via command: java -jar RomRaider0.5.4-371-linux.jar
Which makes a dir, copies in the files and integrates launch parameters into the desktop menu as well as an uninstaller (which just deletes what was created by install).

dschultz · **Posted:** Tue May 01, 2012 8:08 pm

Fearless wrote:

Even if it does, the people all have to assign, or it should be done as above. For example, have you signed a copyright assignment contract with Jared? If not, your name should be on the source as it is copyright by you AND whoever else.

I have not signed/assigned...

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

dschultz wrote:

Installing on Linux is via command: java -jar RomRaider0.5.4-371-linux.jar
Which makes a dir, copies in the files and integrates launch parameters into the desktop menu as well as an uninstaller (which just deletes what was created by install).

OK! Thanks for the information :-) Most appreciated.

Re assignment, I didn't think so, hence the post. Same likely goes for the others. This is the viral nature of GPL :-) As long as those people have gone and not signed/assigned, then it's free forever for everyone. We'll update the files to look better in that regard as we go, no biggy.

Fred.

Fearless · **Joined:** Thu Apr 19, 2012 7:44 am **Posts:** 385

JEP dependency is no longer open source:

Version 3.0 (released 2007/07/01)
No longer available under the GPL license

Latest is 3.4

We're on 2.X

We should look at using something else to achieve this work, not a priority, though.

dschultz · **Posted:** Wed May 02, 2012 3:18 pm

Fearless wrote:

JEP dependency is no longer open source:

Version 3.0 (released 2007/07/01)
No longer available under the GPL license

Latest is 3.4

We're on 2.X

We should look at using something else to achieve this work, not a priority, though.

I don't see a reason to change this as there is still a open source version available.
Do you need additional functionality not currently provided?

RomRaider

Forum rules

Random Stuff To Fix

Who is online