RomRaider Logo

RomRaider

Open Source ECU Tools
 FAQ •  Register •  Login 

RomRaider

Documentation

Community

Developers

It is currently Sat Feb 21, 2026 10:21 pm

All times are UTC




Post new topic Reply to topic  [ 106 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6 ... 8  Next
Author Message
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Fri Jun 15, 2012 6:57 am 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
Hey guys - going to be a little quiet over the next two weeks, I'm travelling with only a dinky toy little netbook - not the easiest thing to disassemble and analyse with!

Managed to have a further look on the plane - two of the switches identified above relate to the FBKC RPM range - i.e. the low and high ranges. Haven't analysed it fully yet, but I guess it would check whether the engine speed falls within the range.

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Fri Jun 15, 2012 6:59 am 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
wrxt4cy wrote:
Heide264 wrote:
Got it today on a full to partial throttle pull. Got a double whammy as well on it.

Normally FBKC pulls 2.2 degrees... pulled 2.8 this time around for some reason. Actual knock? Well, didn't hear anything at least? I definitely felt the timing being pulled though.

See row 8155 or so if you can't open the excel file.

Also worth noting, it sometimes increments back to zero partially over 70 samples or so, sometimes it disappears 10 data samples later. No clear pattern.


Yeah - it started right when you load peaked. That's where I tend to see it.

Sometimes I also see it step back to zero without incrementing down like in your log.

I even saw a strange variation while tuning a 2012 STi a couple days ago. The tune was set to pull 1* and advance .5* on real knock. I was seeing it pull 1.4 but it would advance .5.


Hmm... so it used the alternate retard value, but the normal advance value - if I recall correctly, the routine branches off to the alternate retard value, but still uses the 'normal' advance value - hence the scenario above.

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Fri Jun 15, 2012 9:04 am 
Offline
Senior Member

Joined: Sat Feb 12, 2011 11:27 pm
Posts: 2032
Location: Northern NSW
Found it in a few ROM's now, 0x00010 past the normal FBKC

Now I know what it is, I have been trying to induce it and I can get it from getting a MAF g/sec peak then dropping airflow within 0.25 seconds triggers it. Can also do the same thing on feathering the throttle to get airflow peak and then airflow stall etc


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Fri Jun 15, 2012 2:31 pm 
Offline
Experienced
User avatar

Joined: Fri Mar 02, 2012 6:09 pm
Posts: 183
Location: DSM, IA :: 2011 STi - Dom3.5XTR - E85
td-d wrote:
wrxt4cy wrote:
Heide264 wrote:
Got it today on a full to partial throttle pull. Got a double whammy as well on it.

Normally FBKC pulls 2.2 degrees... pulled 2.8 this time around for some reason. Actual knock? Well, didn't hear anything at least? I definitely felt the timing being pulled though.

See row 8155 or so if you can't open the excel file.

Also worth noting, it sometimes increments back to zero partially over 70 samples or so, sometimes it disappears 10 data samples later. No clear pattern.


Yeah - it started right when you load peaked. That's where I tend to see it.

Sometimes I also see it step back to zero without incrementing down like in your log.

I even saw a strange variation while tuning a 2012 STi a couple days ago. The tune was set to pull 1* and advance .5* on real knock. I was seeing it pull 1.4 but it would advance .5.


Hmm... so it used the alternate retard value, but the normal advance value - if I recall correctly, the routine branches off to the alternate retard value, but still uses the 'normal' advance value - hence the scenario above.


I've seen it use .35* to advance at other times even though I've set it to advance .50*. There is certainly some interesting logic around this and it sounds like there might be references back to load and MAF. I still suspect there could be a learning based component involved since I've seen nearly identical conditions induce this type of FBKC correction and then not induce it the following time.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Sun Jun 17, 2012 2:57 pm 
Offline
Senior Member

Joined: Sat Feb 12, 2011 11:27 pm
Posts: 2032
Location: Northern NSW
Have since found the alternate 'pre-emptive FBKC' in every 32bit ROM I have tuned.

06/07 ECU's, the -1.4 is in the cell address just after FBKC

03-05 XT/LGT is usually within 0x00020


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Mon Jun 18, 2012 11:22 pm 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
There are also references back to closed loop fueling - can you do me a favour and log closed loop fueling target and CL/OL state for me, and try and recreate the conditions for me? If you look at the logs, actual AFR also drops significantly each time this knock occurs.

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Jun 19, 2012 12:15 am 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
Another one of the switches checks whether the Engine Load is above / below the feedback minimum engine load activation threshold.

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Jun 19, 2012 4:30 pm 
Offline
Experienced

Joined: Sat May 07, 2011 3:22 pm
Posts: 144
I have closed loop deactivated - so just running constant open loop

Also, I have always seen it above the minimum FBKC threshold.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Jun 19, 2012 4:38 pm 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
Interesting. Then again, this is the mother of all routines, loads of variables being loaded in, so maybe just a detour. From what I'm gathering, FBKC ranges, engine load, and what I assume is airflow are the main ingredients to this section of the code.

I will need to actually trace the entire routine right from the top to make sure...

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Mon Jul 09, 2012 1:25 pm 
Offline
Experienced

Joined: Sat May 07, 2011 3:22 pm
Posts: 144
Still getting this time to time. I'm curious as to whether you have made any progress on it. I'm mainly concerned regarding if the car actually picked up a detonation event or not.

Appreciate the time you've put into the effort. Thanks.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Jul 10, 2012 9:39 am 
Offline
Senior Member

Joined: Sat Feb 12, 2011 11:27 pm
Posts: 2032
Location: Northern NSW
Heide264 wrote:
Still getting this time to time. I'm curious as to whether you have made any progress on it. I'm mainly concerned regarding if the car actually picked up a detonation event or not.

Appreciate the time you've put into the effort. Thanks.


Link Knock Microphone on, no knock at all. It is pre-emptive to stop a condition the ECU thinks could become knock. This PEKC appears to be under boost error conditions as well ;)


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Jul 10, 2012 9:48 am 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
Heide264 wrote:
Still getting this time to time. I'm curious as to whether you have made any progress on it. I'm mainly concerned regarding if the car actually picked up a detonation event or not.

Appreciate the time you've put into the effort. Thanks.


Haven't had the time to dig back - I'll definitely get to it though, and post up findings.

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Thu Sep 13, 2012 11:11 pm 
Offline
Newbie

Joined: Fri Oct 14, 2011 2:40 am
Posts: 34
Any updates on this ?

I too had suspected something like this. I had never changed my FBKC retard value, but had noticed two very different behaviors in the way the pulled timing is re-advanced.

My suspicion was that the pre-emptive timings gets re-applied really fast (maybe the advance value is the same as the retard size), however "real" knock seemed to get wound back on in the familiar "advancing by 0.35" method.

Doing a "race-change" from 1st to 2nd on a stock tuned MY11 WRX (ADM) would induce up to -4.2 of this (suspected pre-emptive correction) almost every time I tried it (on multi cars).


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Tue Sep 18, 2012 9:11 am 
Offline
Moderator

Joined: Thu May 20, 2010 8:01 am
Posts: 3117
Location: Johannesburg, South Africa
I've not had the time to really dig through this, but I suspect given feedback (excuse the pun) above, that it is the same as this value referenced by COBB:

Feedback Knock Retard Decrement Alternate (Max. CL Target Rich)
-> This value is the step value for each negative change to feedback knock correction when the maximum closed loop fueling target lambda (which changes based on various conditions) is at the "rich" maximum.

So I expect that if I had to follow the logic of the various switches checked prior to branching off to this alternate value, they would relate to CL fueling lambda.

Not convinced that it's preemptive in that case...

_________________
He who dies with the most gadgets wins.

Please do not PM me - use the email option.


Top
 Profile  
 
 Post subject: Re: Preemptive feedback knock correction
PostPosted: Wed Sep 19, 2012 1:13 am 
Offline
Newbie

Joined: Fri Oct 14, 2011 2:40 am
Posts: 34
Interestingly now that you mention COBB, it reminds me of a COBB response to a forum post I read (maybe 12m ago), in reply to people complaining about seeing heaps of FBKC on their OTS tunes, and the COBB guy at the time stated that FBKC was not always trigger by knock..


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 106 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6 ... 8  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 19 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Style based on FI Subsilver by phpBBservice.nl