RomRaider

Excellent!

Which client? Msysgit is pretty lightweight.. I never liked the 'official' github client.

Also, for commit descriptions, be more specific. The best rule of thumb is to just write exactly what you did

The issue with the shift light is coexisting with the knock/lean/egt light. Getting the cruise light logic figured out would be the best option for this IMO.

I tried the official github. I'll try the one you mentioned.

I'll clean up the descriptions from now on. Was really just testing the editing and ended up doing it all.

I was thinking of doing two lights for it. One on each side of the dash for visibility. Seatbelt, brights, ses, and cruise all thought of as options. Cruise is probably the easiest to find though, right?

In theory, the cruise should be very similar to the CEL, as it has a dedicated line to the cluster. Many of the other lights use signals from other modules in the car. In newer models (~2011+) everything to the cluster goes over CAN.

To clean up the existing commit descriptions, the easiest way is to use 'git rebase -i HEAD~7' Its probably best to first do some reading about rebase and the basic commands of the msysgit text editor (vim). To break down that command: -i = interactive mode, HEAD~7 = 7 commits prior to HEAD (current commit).

Eventually, you'll need to rebase your work onto my current master branch (check https://github.com/Merp/MerpMod/network to see the newer commits you're missing). For rebasing like this, its very useful to set up a diff tool. I recommend kdiff3: http://timwise.blogspot.com/2010/09/con ... ol-in.html

Just finished a huge chunk of the Shift light coding. I actually think it will work as-is (barring the errors) but it also my first time coding anything ever so who knows.

Will post up tomorrow.for now I linked it into cel flash to keep it "easy" or at least linked into the current merpmod soce I don't know for sure how to set up new files to be included in the build.

Edit: Committed to Git just now

Nice!

I left some comments on github.

Thanks for the notes. I believe I understood almost all of it. Couple things I need to research to understand fully.
Committed some changes.
It will be fun testing this and implementing it. Even though a shift light to me isn't important its a very cool project to learn on.
I need to learn the IDA portion. I got it set up but didn't start digging too deep.

Figured out the bugs I mentioned on git. I will post up when I get a minute.

Also redid the files off your latest commit.

Replied to a couple, this one in particular: https://github.com/kerchakone/MerpMod/c ... 05a04bfcbe

ECU Analysis forum has a wealth of information for the disassembly side

edited

In your git Definitions.c, externs and boosthacktables don't agree with each other.
Since you unincorporated mapswitch from boosthacks you added more tables to boost hacks but they aren't defined and in the 32bit base. I added them into mine but I don't know if you find places for them specifically or what. Do you manually find a place to add in the tables for each ecm or do you let sharptune do it by itself?

Yep, they need to be added there and in the 32bitbase.

The linker determines the addressing of the tables, based on the romhole addresses in the map file.

I posted a new repository that works with the desktop client. It's my current build. I haven't loaded it yet but I'm running a very similar build.

I added tables to the 32bitbase, I also created a scalar to 100% fix the pgwg max tables but that's not been loaded yet. I also need to add the defs for the boost control limits. These are on my netbook but not my desktop.

I haven't looked into finishing the shiftlight, cruise light or target boost stuff.

There shouldn't be a need for a new repository. This defeats the purpose of using git.

What issues does the desktop client have? And what client specifically? I know the msysgit client works great, and the official github client (when I tried using it) was more or less crippled in comparison.

For the defs: https://github.com/Merp/SubaruDefs/tree/MerpMod is the proper place to commit.

If you have any git questions, feel free to post here, post on IRC, or pm to set up a skype.

I couldn't for the life of me get them to sync with each other. The only way I was able to get anything to work with it was by starting with a fresh repo. I was able to get the official github app to "work."
I forked the defs. I will clean it up and commit it. And submit a pull request.

I'm not sure exactly what you mean by sync?

Desktop and netbook?
1. When finished working, commit & push.
2. When working on new machine, fetch & merge --ff-only, go to step 1.

If things get out of phase (--ff-only won't work) a rebase can fix that. Git stash & git stash pop can also come in handy if you forget #2 before you start working.