|
RomRaider
Documentation
Community
Developers
|
| Author |
Message |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Mon Feb 24, 2014 9:36 pm |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
|
None of the options are available in the GUI github official app that I can see. As soon as I clean up my trashhole of a git I will look into the one you use again.
I'm being extra stupid and using my netbook, PC and imac to do different things. Problem is I can't just stick with the netbook only because the screen is too small.
I committed all the changes made previously. I attempted to do them one at a time to each file but the application wasn't wanting to sync.
From now on commits will be smooth, small changes and often.
I sent through a few pull requests for the 32bitbase and fixes for merpmod plus some stuff you may disagree with in that.
I created a new branch that has the enums and mapswitch changes I mention in the pull request.
Also made a new branch for the shiftlight.
I'm cleaning my git up bit by bit.
|
|
| Top |
|
 |
|
Merp
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Tue Feb 25, 2014 2:44 am |
|
 |
| Experienced |
 |
Joined: Thu Jul 23, 2009 5:46 pm Posts: 863
|
Good stuff  I left some comments. I suggest using the msysgit client to clean things up. it will open the existing repo just fine and offers more functionality in the GUI and full functionality via command line.
_________________ Please do not send me support questions via PM, use the forum instead!
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Wed Feb 26, 2014 11:52 pm |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
|
Downloading msysgit. Having serious issues with the official git for windows. Keeps wanting me to commit changes when there aren't any. Driving me nuts.
Added resolution to pgwgcompmax in 32bitbase. Matches WGmax of OEM tables now. Need to fix the hack tables now.
Getting an error when trying to rebase:
You have unstaged changes. please commit or stash them.
|
|
| Top |
|
 |
|
Merp
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Thu Feb 27, 2014 1:42 am |
|
 |
| Experienced |
 |
Joined: Thu Jul 23, 2009 5:46 pm Posts: 863
|
|
That may be an EOL issue... I will check what EOL settings I'm using on this repo and post later.
_________________ Please do not send me support questions via PM, use the forum instead!
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Thu Feb 27, 2014 3:08 am |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
|
Thanks!
Also you mention a "GUI" for msysgit... Is this a non graphical user interface? I only see command line and a git specific command line. Am I missing something?
And whenever you get the chance, is that the right scalar value you meant? I did pull it from the oem scalar.
Thanks again for your knowledge and guidance.
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Thu Feb 27, 2014 9:39 pm |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
|
With so many Anti lag questions I see, I started to think about an Anti Lag hack idea. Just to see if I can do it. I wrote some basic ideas for the code.
ALS specific tables would include:
Timing Lock or timing additive (subtractive) amount Fuel target lock or Fuel enrichment additive (subtractive) amount WGDC initial if needed Target Boost if needed DBW throttle opening angle table target idle speed if needed. rev limit/hysteresis
Basic idea is to have those tables active when accelerator pedal is 0% and ALS is turned on. Or the DBW table on at all times ALS is engaged if needed to prevent bogging.
An even simpler one could use the revlimit hack with a rev limit/hysteresis and DBW table active with a 0% accelerator angle. It would get lower boost and take longer to build boost but it'd probably work.
Thinking your programming mode would work well for it. Or if there's a way for a cruise resume/on combination could work. Say if you toggle cruise on at the same time as the resume while ALS is off, it switches to on. And if you turn cruise off at the same time as resume while ALS is on, it switches off. Don't know if that would kill cruise control if that's even feasible. It could also be set up through the TGV voltage or rear o2 with a simple relay or switched resistor I suppose.
What do you think? It actually sounds easier than the shift light idea to me. Of course I'm SuperNoob when it comes to this stuff. I'm not too into testing it on my personal car though.
|
|
| Top |
|
 |
|
Merp
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Thu Feb 27, 2014 10:09 pm |
|
 |
| Experienced |
 |
Joined: Thu Jul 23, 2009 5:46 pm Posts: 863
|
|
msysgit from the link in my sig is bundled as command line and GUI. This is the 'official' git client for windows, not to be confused with the 'official' github client.
Regarding antilag, code is already written for launch timing and fueling compensations, having the same effect as the IAT switch hack that some people are using, but with a full table and no switch needed. There is also a WGDC lock, but a launch specific map could be substituted easily for any of those tables. It uses the launch control enabled signal from the merpmod rev limiter.
_________________ Please do not send me support questions via PM, use the forum instead!
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Tue Mar 04, 2014 6:26 am |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
|
Going through IDA for the first time in depth today I marked the DBW tables. I may have found the subroutine that calculates the throttle portion. Need to do some more research and figure out the Ram address for accelerator pedal angle.
Have you mapped that portion? If/when I do get it I'd love to see if I'm right. And actually the logger def probably has it...
I tried xmltoida a month or so ago but it didn't work. I may retry soon but I've just been manually entering the addresses of known values. Teaching myself off of this so I may eventually be able to write a complete piggyback "hack" setup off the merpmod.
Last edited by Professwrx on Tue Mar 04, 2014 7:23 am, edited 1 time in total.
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Tue Mar 04, 2014 7:01 am |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
Merp wrote: msysgit from the link in my sig is bundled as command line and GUI. This is the 'official' git client for windows, not to be confused with the 'official' github client.
Regarding antilag, code is already written for launch timing and fueling compensations, having the same effect as the IAT switch hack that some people are using, but with a full table and no switch needed. There is also a WGDC lock, but a launch specific map could be substituted easily for any of those tables. It uses the launch control enabled signal from the merpmod rev limiter. I've looked through those tables and definitely would implement them. Haven't thought through the wgdc lock portion yet. Very cool stuff though. Fun learning project so far. Thanks!
|
|
| Top |
|
 |
|
Merp
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Tue Mar 04, 2014 4:05 pm |
|
 |
| Experienced |
 |
Joined: Thu Jul 23, 2009 5:46 pm Posts: 863
|
Professwrx wrote: Going through IDA for the first time in depth today I marked the DBW tables. I may have found the subroutine that calculates the throttle portion. Need to do some more research and figure out the Ram address for accelerator pedal angle.
Have you mapped that portion? If/when I do get it I'd love to see if I'm right. And actually the logger def probably has it...
I tried xmltoida a month or so ago but it didn't work. I may retry soon but I've just been manually entering the addresses of known values. Teaching myself off of this so I may eventually be able to write a complete piggyback "hack" setup off the merpmod. Definitely have another go at xmltoidc. It makes the mapping portion MUCH easier. Sharptune has an implementation of this but I have not run it on the latest logger definitions so there may be some bugs to be worked out.
_________________ Please do not send me support questions via PM, use the forum instead!
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Tue Mar 04, 2014 10:11 pm |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
|
Got it working!
FFFF68E4 is that: Accelerator Pedal Angle - 4 bytes? A8DH200x. Is it the same as 202x? Or do I need to start over on that rom? I used my OEM stock .hex file.
|
|
| Top |
|
 |
|
Merp
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Tue Mar 04, 2014 11:58 pm |
|
 |
| Experienced |
 |
Joined: Thu Jul 23, 2009 5:46 pm Posts: 863
|
|
iirc all the changes in a8dh200x -> 202x are in the calibration only, no changes in logic, so it ought to be. I know I did the majority of my work on 200x before switching to 202x and there were zero issues switching. Best to double check though. Use a file diff utility to compare the two stock roms ("fc /b file1 file2 | more" on windows) and then examine the areas that differ.
IDA has an option to reload the input file as well.
_________________ Please do not send me support questions via PM, use the forum instead!
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Fri Mar 07, 2014 12:00 am |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
Merp wrote: iirc all the changes in a8dh200x -> 202x are in the calibration only, no changes in logic, so it ought to be. I know I did the majority of my work on 200x before switching to 202x and there were zero issues switching. Best to double check though. Use a file diff utility to compare the two stock roms ("fc /b file1 file2 | more" on windows) and then examine the areas that differ.
IDA has an option to reload the input file as well. They are the same address, thanks! I've got a coding question for you. I ran some preliminary test code that I dropped into Boosthacks.c and am getting the opposite result I wanted. Code: Quote: if ALS_HACKS
if(pRamVariables->Accelerator <= 3.0 && pRamVariables->BoostPressure <= 30.0) {
pRamVariables->WGDCInitial = 100.0; pRamVariables->WGDCMax = 100.0;
} #else
This should give me a WGDC lock at 100 when not pressing the gas, right? When I flashed it I got WGDC lock when pressing the gas instead. Is there something I am missing?? Thanks for any insight you can give me.
|
|
| Top |
|
 |
|
Merp
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Fri Mar 07, 2014 2:54 am |
|
 |
| Experienced |
 |
Joined: Thu Jul 23, 2009 5:46 pm Posts: 863
|
|
First log that accelerator variable, is it what you expect?
Also, why the variable? just reference the existing one for throttle plate (*pThrottlePlate) or create a new reference (add to the target header manually or through idatohew.xml and .map file)
_________________ Please do not send me support questions via PM, use the forum instead!
|
|
| Top |
|
 |
|
Professwrx
|
Post subject: Re: Merpmod pgwg,pgtb tables Posted: Fri Mar 07, 2014 6:41 am |
|
 |
| Experienced |
Joined: Thu Jan 09, 2014 10:17 pm Posts: 394
|
Merp wrote: First log that accelerator variable, is it what you expect?
Also, why the variable? just reference the existing one for throttle plate (*pThrottlePlate) or create a new reference (add to the target header manually or through idatohew.xml and .map file) Yes, I did log the variable. Other than the scalar being way off it is what it should be. Goes from zero up depending on pedal position. Matches the two byte accelerator pedal in the log, but uses a different scalar. As far as why I am not doing throttleplate.. Depending on how this all plays together, if I use throttle plate as the variable, it will shut itself off as soon as it pulls in more air than it would at idle. With accelerator pedal as input, it can continue to be active until the pedal is pushed a certain % regardless of how much air the engine is ingesting.
|
|
| Top |
|
 |
Who is online |
Users browsing this forum: No registered users and 9 guests |
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot post attachments in this forum
|
|